diff mbox series

[v2] ath11k: Fix the rx_filter flag setting for peer rssi stats

Message ID 1605091117-11005-1-git-send-email-mkenna@codeaurora.org (mailing list archive)
State Accepted
Commit 11af6de4799ee6eeae3730f18fd417414d212e2d
Delegated to: Kalle Valo
Headers show
Series [v2] ath11k: Fix the rx_filter flag setting for peer rssi stats | expand

Commit Message

Maharaja Kennadyrajan Nov. 11, 2020, 10:38 a.m. UTC
Set the rx_filter in ath11k_mac_config_mon_status_default(),
only when the rx_filter value exists in ath11k_debug_rx_filter().

Without this change, rx_filter gets set to 0 and peer rssi stats
aren't updating properly from firmware.

Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01230-QCAHKSWPL_SILICONZ-4

Fixes: ec48d28ba291 ("ath11k: Fix rx_filter flags setting for per peer rx_stats")

Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
---

    V2: Added the "Fixes" tag in the commit message.

 drivers/net/wireless/ath/ath11k/mac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Kalle Valo Nov. 23, 2020, 6:08 p.m. UTC | #1
Maharaja Kennadyrajan <mkenna@codeaurora.org> wrote:

> Set the rx_filter in ath11k_mac_config_mon_status_default(),
> only when the rx_filter value exists in ath11k_debug_rx_filter().
> 
> Without this change, rx_filter gets set to 0 and peer rssi stats
> aren't updating properly from firmware.
> 
> Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01230-QCAHKSWPL_SILICONZ-4
> 
> Fixes: ec48d28ba291 ("ath11k: Fix rx_filter flags setting for per peer rx_stats")
> 
> Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

11af6de4799e ath11k: Fix the rx_filter flag setting for peer rssi stats
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 591dceb..cad4402 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -4144,7 +4144,8 @@  static int ath11k_mac_config_mon_status_default(struct ath11k *ar, bool enable)
 
 	if (enable) {
 		tlv_filter = ath11k_mac_mon_status_filter_default;
-		tlv_filter.rx_filter = ath11k_debugfs_rx_filter(ar);
+		if (ath11k_debugfs_rx_filter(ar))
+			tlv_filter.rx_filter = ath11k_debugfs_rx_filter(ar);
 	}
 
 	for (i = 0; i < ab->hw_params.num_rxmda_per_pdev; i++) {