| Message ID | 1611037955-105333-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] rtlwifi: rtl8192se: Simplify bool comparison. | expand |
On Tue, 2021-01-19 at 14:32 +0800, Jiapeng Zhong wrote: > Fix the follow coccicheck warnings: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: > WARNING: Comparison of 0/1 to bool variable. > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: > WARNING: Comparison of 0/1 to bool variable. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> > --- > Changes in v2: > -Modified subject. > You forget to remove the period at the end of subject. i.e. "rtlwifi: rtl8192se: Simplify bool comparison" --- Ping-Ke
Pkshih <pkshih@realtek.com> writes: > On Tue, 2021-01-19 at 14:32 +0800, Jiapeng Zhong wrote: >> Fix the follow coccicheck warnings: >> >> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: >> WARNING: Comparison of 0/1 to bool variable. >> >> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: >> WARNING: Comparison of 0/1 to bool variable. >> >> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> >> --- >> Changes in v2: >> -Modified subject. >> > > You forget to remove the period at the end of subject. > i.e. > "rtlwifi: rtl8192se: Simplify bool comparison" I can fix that during commit.
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c index 47fabce..aff8ab0 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c @@ -1373,7 +1373,7 @@ static void _rtl92se_gen_refreshledstate(struct ieee80211_hw *hw) struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); struct rtl_led *pled0 = &rtlpriv->ledctl.sw_led0; - if (rtlpci->up_first_time == 1) + if (rtlpci->up_first_time) return; if (rtlpriv->psc.rfoff_reason == RF_CHANGE_BY_IPS) @@ -2302,7 +2302,7 @@ bool rtl92se_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 *valid) bool turnonbypowerdomain = false; /* just 8191se can check gpio before firstup, 92c/92d have fixed it */ - if ((rtlpci->up_first_time == 1) || (rtlpci->being_init_adapter)) + if (rtlpci->up_first_time || rtlpci->being_init_adapter) return false; if (ppsc->swrf_processing)
Fix the follow coccicheck warnings: ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: WARNING: Comparison of 0/1 to bool variable. ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: WARNING: Comparison of 0/1 to bool variable. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> --- Changes in v2: -Modified subject. drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)