diff mbox series

ath11k: Fix 'unused-but-set-parameter' error

Message ID 1636609967-5114-1-git-send-email-quic_seevalam@quicinc.com (mailing list archive)
State Accepted
Commit 624e0a3170309eeb5b729f7a43c1ba3234325f02
Delegated to: Kalle Valo
Headers show
Series ath11k: Fix 'unused-but-set-parameter' error | expand

Commit Message

Seevalamuthu M (QUIC) Nov. 11, 2021, 5:52 a.m. UTC
Below compilation error is reported when built with W=1,

drivers/net/wireless/ath/ath11k/mac.c:5408:22: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]

changed_flags is set, but left unused. So, remove unnecessary set.
Compile tested only.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Seevalamuthu Mariappan <quic_seevalam@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/mac.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Kalle Valo Nov. 15, 2021, 9:18 a.m. UTC | #1
Seevalamuthu Mariappan <quic_seevalam@quicinc.com> wrote:

> Below compilation error is reported when built with W=1,
> 
> drivers/net/wireless/ath/ath11k/mac.c:5408:22: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> 
> changed_flags is set, but left unused. So, remove unnecessary set.
> Compile tested only.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Seevalamuthu Mariappan <quic_seevalam@quicinc.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

624e0a317030 ath11k: Fix 'unused-but-set-parameter' error
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 89810b2..6f3130d 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -5919,7 +5919,6 @@  static void ath11k_mac_op_configure_filter(struct ieee80211_hw *hw,
 
 	mutex_lock(&ar->conf_mutex);
 
-	changed_flags &= SUPPORTED_FILTERS;
 	*total_flags &= SUPPORTED_FILTERS;
 	ar->filter_flags = *total_flags;