diff mbox series

mt76: mt7921: fix mt7921s Kconfig

Message ID 1ce6cb04ba1ab5aabd2b06b45fd8266537ef5359.1634893214.git.lorenzo@kernel.org (mailing list archive)
State Accepted
Commit 8603caaec98f7a46419a661f306abfaf2f18ec4b
Delegated to: Kalle Valo
Headers show
Series mt76: mt7921: fix mt7921s Kconfig | expand

Commit Message

Lorenzo Bianconi Oct. 22, 2021, 9:02 a.m. UTC
Add missing MMC dependency in mt7921s Kconfig

Fixes: 48fab5bbef409 ("mt76: mt7921: introduce mt7921s support")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/net/wireless/mediatek/mt76/mt7921/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Kalle Valo Oct. 23, 2021, 7:11 a.m. UTC | #1
Lorenzo Bianconi <lorenzo@kernel.org> writes:

> Add missing MMC dependency in mt7921s Kconfig
>
> Fixes: 48fab5bbef409 ("mt76: mt7921: introduce mt7921s support")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

I had missed this before I submitted the pull request to net-next :(

Felix, I'll take this directly to wireless-drivers-next so that I can
submit the fix to net-next ASAP. Please drop it from your tree.
Kalle Valo Oct. 23, 2021, 7:28 a.m. UTC | #2
Lorenzo Bianconi <lorenzo@kernel.org> wrote:

> Add missing MMC dependency in mt7921s Kconfig:
> 
> ld: drivers/net/wireless/mediatek/mt76/sdio.o: in function `mt76s_rr':
> sdio.c:(.text+0x1263): undefined reference to `sdio_claim_host'
> ld: sdio.c:(.text+0x1278): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x12c8): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x1327): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x134d): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x138c): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x140f): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x1498): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x14e5): undefined reference to `sdio_release_host'
> ld: drivers/net/wireless/mediatek/mt76/sdio.o: in function `mt76s_wr':
> sdio.c:(.text+0x1599): undefined reference to `sdio_claim_host'
> ld: sdio.c:(.text+0x15ae): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x15f9): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x1646): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x16a5): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x16cb): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x170a): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x1782): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x17e9): undefined reference to `sdio_release_host'
> 
> Fixes: 48fab5bbef409 ("mt76: mt7921: introduce mt7921s support")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Patch applied to wireless-drivers-next.git, thanks.

8603caaec98f mt76: mt7921: fix mt7921s Kconfig
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/Kconfig b/drivers/net/wireless/mediatek/mt76/mt7921/Kconfig
index ce3a06227901..71154fc2a87c 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/Kconfig
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/Kconfig
@@ -19,6 +19,7 @@  config MT7921S
 	select MT76_SDIO
 	select MT7921_COMMON
 	depends on MAC80211
+	depends on MMC
 	help
 	  This adds support for MT7921S 802.11ax 2x2:2SS wireless devices.