diff mbox

cfg80211: don't report SME connection errs at SIOCSIW{FREQ/AP/ESSID}

Message ID 200909141323.44245.hs4233@mail.mn-solutions.de (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Holger Schurig Sept. 14, 2009, 11:23 a.m. UTC
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>

---

This fixes

1252921276.182218: Trying to associate with 00:1b:53:11:dc:40 (SSID='TEST' freq=2412 MHz)
ioctl[SIOCSIWFREQ]: No such file or directory
ioctl[SIOCSIWESSID]: No such file or directory
1252921276.268451: Association request to the driver failed
1252921276.355482: Associated with 00:1b:53:11:dc:40

and makes it

1252921276.182218: Trying to associate with 00:1b:53:11:dc:40 (SSID='TEST' freq=2412 MHz)
1252921276.355482: Associated with 00:1b:53:11:dc:40

However, otherwise this hasn't been greatly tested and I
don't have a great understanding of cfg80211, SME, etc ...

Comments

Johannes Berg Sept. 14, 2009, 5:43 p.m. UTC | #1
On Mon, 2009-09-14 at 13:23 +0200, Holger Schurig wrote:
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
> 
> ---
> 
> This fixes
> 
> 1252921276.182218: Trying to associate with 00:1b:53:11:dc:40 (SSID='TEST' freq=2412 MHz)
> ioctl[SIOCSIWFREQ]: No such file or directory
> ioctl[SIOCSIWESSID]: No such file or directory
> 1252921276.268451: Association request to the driver failed
> 1252921276.355482: Associated with 00:1b:53:11:dc:40
> 
> and makes it
> 
> 1252921276.182218: Trying to associate with 00:1b:53:11:dc:40 (SSID='TEST' freq=2412 MHz)
> 1252921276.355482: Associated with 00:1b:53:11:dc:40
> 
> However, otherwise this hasn't been greatly tested and I
> don't have a great understanding of cfg80211, SME, etc ...

And doesn't look correct to me at all. probably something missing wrt.
disconnect() while connecting.

johannes

> Index: linux-wl/net/wireless/wext-sme.c
> ===================================================================
> --- linux-wl.orig/net/wireless/wext-sme.c	2009-09-14 12:05:54.000000000 +0200
> +++ linux-wl/net/wireless/wext-sme.c	2009-09-14 12:06:09.000000000 +0200
> @@ -110,7 +110,7 @@ int cfg80211_mgd_wext_siwfreq(struct net
>  		goto out;
>  	}
>  
> -	err = cfg80211_mgd_wext_connect(rdev, wdev);
> +	cfg80211_mgd_wext_connect(rdev, wdev);
>   out:
>  	wdev_unlock(wdev);
>  	mutex_unlock(&rdev->devlist_mtx);
> @@ -196,7 +196,7 @@ int cfg80211_mgd_wext_siwessid(struct ne
>  
>  	wdev->wext.connect.crypto.control_port = false;
>  
> -	err = cfg80211_mgd_wext_connect(rdev, wdev);
> +	cfg80211_mgd_wext_connect(rdev, wdev);
>   out:
>  	wdev_unlock(wdev);
>  	mutex_unlock(&rdev->devlist_mtx);
> @@ -283,7 +283,7 @@ int cfg80211_mgd_wext_siwap(struct net_d
>  	} else
>  		wdev->wext.connect.bssid = NULL;
>  
> -	err = cfg80211_mgd_wext_connect(rdev, wdev);
> +	cfg80211_mgd_wext_connect(rdev, wdev);
>   out:
>  	wdev_unlock(wdev);
>  	mutex_unlock(&rdev->devlist_mtx);
>
Holger Schurig Sept. 15, 2009, 6:21 a.m. UTC | #2
> And doesn't look correct to me at all. probably something
> missing wrt. disconnect() while connecting.

Can you then outline the right solution ?
diff mbox

Patch

Index: linux-wl/net/wireless/wext-sme.c
===================================================================
--- linux-wl.orig/net/wireless/wext-sme.c	2009-09-14 12:05:54.000000000 +0200
+++ linux-wl/net/wireless/wext-sme.c	2009-09-14 12:06:09.000000000 +0200
@@ -110,7 +110,7 @@  int cfg80211_mgd_wext_siwfreq(struct net
 		goto out;
 	}
 
-	err = cfg80211_mgd_wext_connect(rdev, wdev);
+	cfg80211_mgd_wext_connect(rdev, wdev);
  out:
 	wdev_unlock(wdev);
 	mutex_unlock(&rdev->devlist_mtx);
@@ -196,7 +196,7 @@  int cfg80211_mgd_wext_siwessid(struct ne
 
 	wdev->wext.connect.crypto.control_port = false;
 
-	err = cfg80211_mgd_wext_connect(rdev, wdev);
+	cfg80211_mgd_wext_connect(rdev, wdev);
  out:
 	wdev_unlock(wdev);
 	mutex_unlock(&rdev->devlist_mtx);
@@ -283,7 +283,7 @@  int cfg80211_mgd_wext_siwap(struct net_d
 	} else
 		wdev->wext.connect.bssid = NULL;
 
-	err = cfg80211_mgd_wext_connect(rdev, wdev);
+	cfg80211_mgd_wext_connect(rdev, wdev);
  out:
 	wdev_unlock(wdev);
 	mutex_unlock(&rdev->devlist_mtx);