diff mbox

[1/3] pcmcia: add PCMCIA_DEVICE_MANF_CARD_PROD_ID3

Message ID 20110726225235.29951.70265.stgit@mj.roinet.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Pavel Roskin July 26, 2011, 10:52 p.m. UTC
This is needed to match wireless cards with Intersil firmware that have
ID 0x0156:0x0002 and the third ID "Version 01.02".  Such cards are
currently matched by orinoco_cs, which doesn't support WPA.  They should
be matched by hostap_cs.

The first and the second product ID vary widely, so there are few users
with some particular IDs.  Of those, very few can submit a patch for
hostap_cs or write a useful bugreport.  It's still important to support
their hardware properly.

With PCMCIA_DEVICE_MANF_CARD_PROD_ID3, it should be possible to cover
the remaining Intersil based designs that kept the numeric ID and the
"version" of the reference design.

Signed-off-by: Pavel Roskin <proski@gnu.org>
---
 include/pcmcia/device_id.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Dominik Brodowski July 29, 2011, 4 p.m. UTC | #1
Applied all three patches to -pcmcia.

Thanks,
	Dominik

On Tue, Jul 26, 2011 at 06:52:35PM -0400, Pavel Roskin wrote:
> This is needed to match wireless cards with Intersil firmware that have
> ID 0x0156:0x0002 and the third ID "Version 01.02".  Such cards are
> currently matched by orinoco_cs, which doesn't support WPA.  They should
> be matched by hostap_cs.
> 
> The first and the second product ID vary widely, so there are few users
> with some particular IDs.  Of those, very few can submit a patch for
> hostap_cs or write a useful bugreport.  It's still important to support
> their hardware properly.
> 
> With PCMCIA_DEVICE_MANF_CARD_PROD_ID3, it should be possible to cover
> the remaining Intersil based designs that kept the numeric ID and the
> "version" of the reference design.
> 
> Signed-off-by: Pavel Roskin <proski@gnu.org>
> ---
>  include/pcmcia/device_id.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/include/pcmcia/device_id.h b/include/pcmcia/device_id.h
> index 63e5b8f..00dbfac 100644
> --- a/include/pcmcia/device_id.h
> +++ b/include/pcmcia/device_id.h
> @@ -95,6 +95,15 @@
>  	.prod_id = { (v1), NULL, NULL, NULL }, \
>  	.prod_id_hash = { (vh1), 0, 0, 0 }, }
>  
> +#define PCMCIA_DEVICE_MANF_CARD_PROD_ID3(manf, card, v3, vh3) { \
> +	.match_flags = PCMCIA_DEV_ID_MATCH_MANF_ID| \
> +			PCMCIA_DEV_ID_MATCH_CARD_ID| \
> +			PCMCIA_DEV_ID_MATCH_PROD_ID3, \
> +	.manf_id = (manf), \
> +	.card_id = (card), \
> +	.prod_id = { NULL, NULL, (v3), NULL }, \
> +	.prod_id_hash = { 0, 0, (vh3), 0 }, }
> +
>  
>  /* multi-function devices */
>  
> 
> _______________________________________________
> Linux PCMCIA reimplementation list
> http://lists.infradead.org/mailman/listinfo/linux-pcmcia
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pavel Roskin July 29, 2011, 6:27 p.m. UTC | #2
On 07/29/2011 12:00 PM, Dominik Brodowski wrote:
> Applied all three patches to -pcmcia.

Thank you!
diff mbox

Patch

diff --git a/include/pcmcia/device_id.h b/include/pcmcia/device_id.h
index 63e5b8f..00dbfac 100644
--- a/include/pcmcia/device_id.h
+++ b/include/pcmcia/device_id.h
@@ -95,6 +95,15 @@ 
 	.prod_id = { (v1), NULL, NULL, NULL }, \
 	.prod_id_hash = { (vh1), 0, 0, 0 }, }
 
+#define PCMCIA_DEVICE_MANF_CARD_PROD_ID3(manf, card, v3, vh3) { \
+	.match_flags = PCMCIA_DEV_ID_MATCH_MANF_ID| \
+			PCMCIA_DEV_ID_MATCH_CARD_ID| \
+			PCMCIA_DEV_ID_MATCH_PROD_ID3, \
+	.manf_id = (manf), \
+	.card_id = (card), \
+	.prod_id = { NULL, NULL, (v3), NULL }, \
+	.prod_id_hash = { 0, 0, (vh3), 0 }, }
+
 
 /* multi-function devices */