diff mbox

[v2] rt2x00: rt2800lib: no need to toggle RF R30 bit 7 twice

Message ID 20131007080201.GA18265@ns.kevlo.org (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Kevin Lo Oct. 7, 2013, 8:02 a.m. UTC
In rt2800_config_channel_rf3xxx(), there's no need to toggle
RF R30 bit 7 twice. 

Signed-off-by: Kevin Lo <kevlo@kevlo.org>
---
Changes since v1:
  - the previous patch was malformed
--- 

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Stanislaw Gruszka Oct. 8, 2013, 10:47 a.m. UTC | #1
On Mon, Oct 07, 2013 at 04:02:01PM +0800, Kevin Lo wrote:
> In rt2800_config_channel_rf3xxx(), there's no need to toggle
> RF R30 bit 7 twice. 
> 
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>

This one is fine.

Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 25aaa5e..65b4416 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -2029,13 +2029,6 @@  static void rt2800_config_channel_rf3xxx(struct rt2x00_dev *rt2x00dev,
 			  rt2x00dev->default_ant.tx_chain_num <= 2);
 	rt2800_rfcsr_write(rt2x00dev, 1, rfcsr);
 
-	rt2800_rfcsr_read(rt2x00dev, 30, &rfcsr);
-	rt2x00_set_field8(&rfcsr, RFCSR30_RF_CALIBRATION, 1);
-	rt2800_rfcsr_write(rt2x00dev, 30, rfcsr);
-	msleep(1);
-	rt2x00_set_field8(&rfcsr, RFCSR30_RF_CALIBRATION, 0);
-	rt2800_rfcsr_write(rt2x00dev, 30, rfcsr);
-
 	rt2800_rfcsr_read(rt2x00dev, 23, &rfcsr);
 	rt2x00_set_field8(&rfcsr, RFCSR23_FREQ_OFFSET, rt2x00dev->freq_offset);
 	rt2800_rfcsr_write(rt2x00dev, 23, rfcsr);