| Message ID | 20131026192053.GA10494@fireworks (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Sat, Oct 26, 2013 at 10:20:53PM +0300, Georgiana Rodica Chelu wrote: > WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... > to printk(KERN_WARNING ... > > Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> > --- > drivers/net/wireless/adm8211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Like Sarah said, we can't take these as they are not against the staging tree. And even if they were: > diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c > index f9a24e5..e36d54d 100644 > --- a/drivers/net/wireless/adm8211.c > +++ b/drivers/net/wireless/adm8211.c > @@ -151,7 +151,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev) > else > priv->rf_type = ADM8211_TYPE_AIROHA; > > - printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n", > + pr_warn("%s (adm8211): Unknown RFtype %d\n", You didn't read the message that sparse was telling you, why didn't you convert this to netdev_warn() instead? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c index f9a24e5..e36d54d 100644 --- a/drivers/net/wireless/adm8211.c +++ b/drivers/net/wireless/adm8211.c @@ -151,7 +151,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev) else priv->rf_type = ADM8211_TYPE_AIROHA; - printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n", + pr_warn("%s (adm8211): Unknown RFtype %d\n", pci_name(priv->pdev), (cr49 >> 3) & 0x7); }
WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> --- drivers/net/wireless/adm8211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)