diff mbox

rsi: rsi_91x: misleading debug printk

Message ID 20140328082733.GK25192@mwanda (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Dan Carpenter March 28, 2014, 8:27 a.m. UTC 
There is a missing set of curly braces here so the debug output says
"Probe confirm received" unintentionally.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

John W. Linville March 28, 2014, 1:07 p.m. UTC | #1 
;-)

goto fail;
goto fail;

Thanks, Dan!

On Fri, Mar 28, 2014 at 11:27:33AM +0300, Dan Carpenter wrote:
> There is a missing set of curly braces here so the debug output says
> "Probe confirm received" unintentionally.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
> index ef37d4b..2361a68 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
> @@ -1292,10 +1292,11 @@ int rsi_mgmt_pkt_recv(struct rsi_common *common, u8 *msg)
>  			return -EINVAL;
>  		}
>  	} else if (msg_type == TX_STATUS_IND) {
> -		if (msg[15] == PROBEREQ_CONFIRM)
> +		if (msg[15] == PROBEREQ_CONFIRM) {
>  			common->mgmt_q_block = false;
>  			rsi_dbg(FSM_ZONE, "%s: Probe confirm received\n",
>  				__func__);
> +		}
>  	} else {
>  		return rsi_mgmt_pkt_to_core(common, msg, msg_len, msg_type);
>  	}
>
diff mbox

Patch

diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index ef37d4b..2361a68 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -1292,10 +1292,11 @@  int rsi_mgmt_pkt_recv(struct rsi_common *common, u8 *msg)
 			return -EINVAL;
 		}
 	} else if (msg_type == TX_STATUS_IND) {
-		if (msg[15] == PROBEREQ_CONFIRM)
+		if (msg[15] == PROBEREQ_CONFIRM) {
 			common->mgmt_q_block = false;
 			rsi_dbg(FSM_ZONE, "%s: Probe confirm received\n",
 				__func__);
+		}
 	} else {
 		return rsi_mgmt_pkt_to_core(common, msg, msg_len, msg_type);
 	}