| Message ID | 20150511115325.GA5092@bytefire-computer (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kalle Valo |
| Headers | show |
> This patch fixes these checkpatch.pl errors around a single switch-case > block: > > ERROR: switch and case should be at the same indent > ERROR: trailing statements should be on next line > > More specifically, the fix has been applied to the five occurances of > the errors listed below. > > ERROR: switch and case should be at the same indent > #1100: FILE: adm8211.c:1100: > + switch (cline) { > [...] > + default: reg |= (0x0 << 14); > > ERROR: trailing statements should be on next line > #1101: FILE: adm8211.c:1101: > + case 0x8: reg |= (0x1 << 14); > > ERROR: trailing statements should be on next line > #1103: FILE: adm8211.c:1103: > + case 0x16: reg |= (0x2 << 14); > > ERROR: trailing statements should be on next line > #1105: FILE: adm8211.c:1105: > + case 0x32: reg |= (0x3 << 14); > > ERROR: trailing statements should be on next line > #1107: FILE: adm8211.c:1107: > + default: reg |= (0x0 << 14); > > > Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com> Thanks, 2 patches applied to wireless-drivers-next.git: f5c65f38912e adm8211: fix checkpatch errors for indentation and new line fe0a483ecf44 adm8211: fixed the possible pci cache line sizes inside switch-case Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c index f07a618..058fb4b 100644 --- a/drivers/net/wireless/adm8211.c +++ b/drivers/net/wireless/adm8211.c @@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev) pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline); switch (cline) { - case 0x8: reg |= (0x1 << 14); - break; - case 0x16: reg |= (0x2 << 14); - break; - case 0x32: reg |= (0x3 << 14); - break; - default: reg |= (0x0 << 14); - break; + case 0x8: + reg |= (0x1 << 14); + break; + case 0x16: + reg |= (0x2 << 14); + break; + case 0x32: + reg |= (0x3 << 14); + break; + default: + reg |= (0x0 << 14); + break; } }
This patch fixes these checkpatch.pl errors around a single switch-case block: ERROR: switch and case should be at the same indent ERROR: trailing statements should be on next line More specifically, the fix has been applied to the five occurances of the errors listed below. ERROR: switch and case should be at the same indent #1100: FILE: adm8211.c:1100: + switch (cline) { [...] + default: reg |= (0x0 << 14); ERROR: trailing statements should be on next line #1101: FILE: adm8211.c:1101: + case 0x8: reg |= (0x1 << 14); ERROR: trailing statements should be on next line #1103: FILE: adm8211.c:1103: + case 0x16: reg |= (0x2 << 14); ERROR: trailing statements should be on next line #1105: FILE: adm8211.c:1105: + case 0x32: reg |= (0x3 << 14); ERROR: trailing statements should be on next line #1107: FILE: adm8211.c:1107: + default: reg |= (0x0 << 14); Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com> --- drivers/net/wireless/adm8211.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)