diff mbox

iwlwifi: mvm: silence unintialized variable warning

Message ID 20160504061954.GD22064@mwanda (mailing list archive)
State Accepted
Delegated to: Johannes Berg
Headers show

Commit Message

Dan Carpenter May 4, 2016, 6:19 a.m. UTC 
"max_amsdu_len" isn't set if kstrtouint() fails.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Luca Coelho May 9, 2016, 11:45 a.m. UTC | #1 
On Wed, 2016-05-04 at 09:19 +0300, Dan Carpenter wrote:
> "max_amsdu_len" isn't set if kstrtouint() fails.

> 

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>


I'm also pushing this one via our internal tree.  Thanks!

--
Luca.
diff mbox

Patch

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
index 362a546..cb8db23 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
@@ -1020,6 +1020,8 @@  static ssize_t iwl_dbgfs_max_amsdu_len_write(struct iwl_mvm *mvm,
 	int ret;
 
 	ret = kstrtouint(buf, 0, &max_amsdu_len);
+	if (ret)
+		return ret;
 
 	if (max_amsdu_len > IEEE80211_MAX_MPDU_LEN_VHT_11454)
 		return -EINVAL;