Message ID | 20160918063024.2535-1-chaehyun.lim@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Commit | b93015057e31933e1ab600290e014779efe5b5a3 |
Delegated to: | Kalle Valo |
Headers | show |
Chaehyun Lim <chaehyun.lim@gmail.com> wrote: > When building with W=1, we got one warning as belows: > drivers/net/wireless/ath/ath6kl/wmi.c:3509:6: warning: variable ‘ret’ > set but not used [-Wunused-but-set-variable] > > At the end of ath6kl_wmi_set_pvb_cmd, it is returned by 0 regardless of > return value of ath6kl_wmi_cmd_send. > This patch fixes return value from 0 to ret that has result of > ath6kl_wmi_cmd_send execution. > > Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Patch applied to ath-next branch of ath.git, thanks. b93015057e31 ath6kl: fix return value in ath6kl_wmi_set_pvb_cmd
diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index b8cf04d..3fd1cc9 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -3520,7 +3520,7 @@ int ath6kl_wmi_set_pvb_cmd(struct wmi *wmi, u8 if_idx, u16 aid, ret = ath6kl_wmi_cmd_send(wmi, if_idx, skb, WMI_AP_SET_PVB_CMDID, NO_SYNC_WMIFLAG); - return 0; + return ret; } int ath6kl_wmi_set_rx_frame_format_cmd(struct wmi *wmi, u8 if_idx,
When building with W=1, we got one warning as belows: drivers/net/wireless/ath/ath6kl/wmi.c:3509:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] At the end of ath6kl_wmi_set_pvb_cmd, it is returned by 0 regardless of return value of ath6kl_wmi_cmd_send. This patch fixes return value from 0 to ret that has result of ath6kl_wmi_cmd_send execution. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> --- drivers/net/wireless/ath/ath6kl/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)