| Message ID | 20161109055048.GA27520@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Luca Coelho |
| Headers | show |
On Tue, 2016-11-08 at 21:50 -0800, Kirtika Ruchandani wrote: > shift_param is defined and set in iwl_pcie_load_cpu_sections > but not used. Fix this to avoid -Wunused-but-set-variable > warning. > The code using it turned into dead code with commit dcab8ecd5617 > which added a separate function iwl_pcie_load_given_ucode_8000 > (then 8000b) for IWL_DEVICE_FAMILY_8000. Commit 76f8c0e17edc > removed the dead code but left shift_param as is. > > iwlwifi/pcie/trans.c: In function ‘iwl_pcie_load_cpu_sections’: > iwlwifi/pcie/trans.c:871:6: warning: variable ‘shift_param’ set but not used [-Wunused-but-set-variable] > > Fixes: dcab8ecd5617 (iwlwifi: mvm: support ucode load for family_8000 B0 only) > Fixes: 76f8c0e17edc (iwlwifi: pcie: remove dead code) > > Signed-off-by: Kirtika Ruchandani <kirtika@google.com> > Cc: Sara Sharon <sara.sharon@intel.com> > Cc: Luca Coelho <luciano.coelho@intel.com> > Cc: Eran Harary <eran.harary@intel.com> I'll remove Harary's Cc here too, since this email is not valid anymore and I don't know his new one (and he probably doesn't care anymore anyway). -- Luca.
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c index ae95533..1b27a39 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c @@ -868,15 +868,12 @@ static int iwl_pcie_load_cpu_sections(struct iwl_trans *trans, int cpu, int *first_ucode_section) { - int shift_param; int i, ret = 0; u32 last_read_idx = 0; if (cpu == 1) { - shift_param = 0; *first_ucode_section = 0; } else { - shift_param = 16; (*first_ucode_section)++; }
shift_param is defined and set in iwl_pcie_load_cpu_sections but not used. Fix this to avoid -Wunused-but-set-variable warning. The code using it turned into dead code with commit dcab8ecd5617 which added a separate function iwl_pcie_load_given_ucode_8000 (then 8000b) for IWL_DEVICE_FAMILY_8000. Commit 76f8c0e17edc removed the dead code but left shift_param as is. iwlwifi/pcie/trans.c: In function ‘iwl_pcie_load_cpu_sections’: iwlwifi/pcie/trans.c:871:6: warning: variable ‘shift_param’ set but not used [-Wunused-but-set-variable] Fixes: dcab8ecd5617 (iwlwifi: mvm: support ucode load for family_8000 B0 only) Fixes: 76f8c0e17edc (iwlwifi: pcie: remove dead code) Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Cc: Sara Sharon <sara.sharon@intel.com> Cc: Luca Coelho <luciano.coelho@intel.com> Cc: Eran Harary <eran.harary@intel.com> Cc: Liad Kaufman <liad.kaufman@intel.com> Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 3 --- 1 file changed, 3 deletions(-)