diff mbox

[v3] wlcore: disable multicast filter in AP mode

Message ID 20170131124431.11675-1-i-hunter1@ti.com (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show

Commit Message

Iain Hunter Jan. 31, 2017, 12:44 p.m. UTC 
Enable AP support for allmulticast for MDNS. It can be enabled by bringing
up the interface with ip command with argument allmulticast on

Signed-off-by:Iain Hunter <i-hunter1@ti.com>
---

PATCH v3: fixes tabbing

 drivers/net/wireless/ti/wlcore/main.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Kalle Valo Feb. 2, 2017, 6:23 a.m. UTC | #1 
Iain Hunter <drhunter95@gmail.com> writes:

> Enable AP support for allmulticast for MDNS. It can be enabled by bringing
> up the interface with ip command with argument allmulticast on
>
> Signed-off-by:Iain Hunter <i-hunter1@ti.com>

There should be a space after ':' and before your name.

> --- a/drivers/net/wireless/ti/wlcore/main.c
> +++ b/drivers/net/wireless/ti/wlcore/main.c
> @@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
>  			if (ret < 0)
>  				goto out_sleep;
>  		}
> +
> +        /*
> +         * If interface in AP mode and created with allmulticast then disable
> +         * the firmware filters so that all multicast packets are passed
> +         * This is mandatory for MDNS based discovery protocols 
> +         */
> + 		if (wlvif->bss_type == BSS_TYPE_AP_BSS) {

The comment looks wrongly indented.

> + 			if (*total & FIF_ALLMULTI) {
> +				ret = wl1271_acx_group_address_tbl(wl, wlvif,
> +							false,
> +							NULL, 0);
> +				if (ret < 0)
> +					goto out_sleep;
> +				}

Also the closing bracket here is not indented correctly.
diff mbox

Patch

diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 3241e9eba73..7d3f15d5d5c 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -3281,6 +3281,21 @@  static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
 			if (ret < 0)
 				goto out_sleep;
 		}
+
+        /*
+         * If interface in AP mode and created with allmulticast then disable
+         * the firmware filters so that all multicast packets are passed
+         * This is mandatory for MDNS based discovery protocols 
+         */
+ 		if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
+ 			if (*total & FIF_ALLMULTI) {
+				ret = wl1271_acx_group_address_tbl(wl, wlvif,
+							false,
+							NULL, 0);
+				if (ret < 0)
+					goto out_sleep;
+				}
+		}
 	}
 
 	/*