| Message ID | 20170207202035.64224-2-nbd@nbd.name (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On Tue, Feb 07, 2017 at 09:20:33PM +0100, Felix Fietkau wrote: > Signed-off-by: Felix Fietkau <nbd@nbd.name> Commit msg? Also, use "dt-bindings: net: " for the subject prefix. > --- > .../bindings/net/wireless/mediatek,mt76.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt > new file mode 100644 > index 000000000000..19522ab97d62 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt > @@ -0,0 +1,24 @@ > +* MediaTek mt76xx devices > + > +This node provides properties for configuring the MediaTek mt76xx wireless > +device. The node is expected to be specified as a child node of the PCI > +controller to which the wireless chip is connected. > + > +Optional properties: > + > +- mac-address: See ethernet.txt in the parent directory > +- local-mac-address: See ethernet.txt in the parent directory > +- ieee80211-freq-limit: See ieee80211.txt > +- mediatek,mtd-eeprom: Specify a MTD partition + offset containing EEPROM data > + > +&pcie { > + status = "okay"; > + > + pcie0 { > + wifi@0,0 { > + reg = <0x0000 0 0 0 0>; > + ieee80211-freq-limit = <5000000 6000000>; > + mediatek,mtd-eeprom = <&factory 0x8000>; > + }; > + }; > +}; > -- > 2.11.0 >
Rob Herring <robh@kernel.org> writes: > On Tue, Feb 07, 2017 at 09:20:33PM +0100, Felix Fietkau wrote: >> Signed-off-by: Felix Fietkau <nbd@nbd.name> > > Commit msg? Also, use "dt-bindings: net: " for the subject prefix. Felix, are you planning to submit v6? Now that we are close to -rc1 release it's the best time to get this driver merged. Also in patch 3 it would be good to have longer commit log, for example describing what works (and what not), what modes are supported etc. I applied this to pending branch for kbuild bot testing: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/log/?h=pending
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt new file mode 100644 index 000000000000..19522ab97d62 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt @@ -0,0 +1,24 @@ +* MediaTek mt76xx devices + +This node provides properties for configuring the MediaTek mt76xx wireless +device. The node is expected to be specified as a child node of the PCI +controller to which the wireless chip is connected. + +Optional properties: + +- mac-address: See ethernet.txt in the parent directory +- local-mac-address: See ethernet.txt in the parent directory +- ieee80211-freq-limit: See ieee80211.txt +- mediatek,mtd-eeprom: Specify a MTD partition + offset containing EEPROM data + +&pcie { + status = "okay"; + + pcie0 { + wifi@0,0 { + reg = <0x0000 0 0 0 0>; + ieee80211-freq-limit = <5000000 6000000>; + mediatek,mtd-eeprom = <&factory 0x8000>; + }; + }; +};
Signed-off-by: Felix Fietkau <nbd@nbd.name> --- .../bindings/net/wireless/mediatek,mt76.txt | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt