diff mbox

wireless/atmel: remove time_t usage

Message ID 20170223161445.19200-1-alexandre.belloni@free-electrons.com (mailing list archive)
State Accepted
Commit 5c5105666de5ac1eef6c3b0710b88d5536b7f6dd
Delegated to: Kalle Valo
Headers show

Commit Message

Alexandre Belloni Feb. 23, 2017, 4:14 p.m. UTC
last_qual never really holds a time. It only holds jiffies. Make it the
same type as jiffies.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/net/wireless/atmel/atmel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo March 8, 2017, 3:13 p.m. UTC | #1
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> last_qual never really holds a time. It only holds jiffies. Make it the
> same type as jiffies.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

The title should start with "atmel:", I can fix that during commit.
Alexandre Belloni March 8, 2017, 4:10 p.m. UTC | #2
Hi,

On 08/03/2017 at 15:13:40 +0000, Kalle Valo wrote:
> Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> > last_qual never really holds a time. It only holds jiffies. Make it the
> > same type as jiffies.
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> The title should start with "atmel:", I can fix that during commit.
> 

If you prefer, I can send a v2
Kalle Valo March 8, 2017, 6:53 p.m. UTC | #3
Alexandre Belloni <alexandre.belloni@free-electrons.com> writes:

> Hi,
>
> On 08/03/2017 at 15:13:40 +0000, Kalle Valo wrote:
>> Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
>> > last_qual never really holds a time. It only holds jiffies. Make it the
>> > same type as jiffies.
>> > 
>> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> 
>> The title should start with "atmel:", I can fix that during commit.
>> 
>
> If you prefer, I can send a v2

Thanks, but no need. I can easily edit the commit log when I commit it.
Kalle Valo March 20, 2017, 4:43 p.m. UTC | #4
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> last_qual never really holds a time. It only holds jiffies. Make it the
> same type as jiffies.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Patch applied to wireless-drivers-next.git, thanks.

5c5105666de5 atmel: remove time_t usage
diff mbox

Patch

diff --git a/drivers/net/wireless/atmel/atmel.c b/drivers/net/wireless/atmel/atmel.c
index e12f62356fd1..27b110dc8cc6 100644
--- a/drivers/net/wireless/atmel/atmel.c
+++ b/drivers/net/wireless/atmel/atmel.c
@@ -513,7 +513,7 @@  struct atmel_private {
 	} station_state;
 
 	int operating_mode, power_mode;
-	time_t last_qual;
+	unsigned long last_qual;
 	int beacons_this_sec;
 	int channel;
 	int reg_domain, config_reg_domain;