diff mbox

staging: rtl8188eu: force driver to be built as a module

Message ID 20170411091953.25069-1-hdegoede@redhat.com (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show

Commit Message

Hans de Goede April 11, 2017, 9:19 a.m. UTC
The rtl8188eu driver defines a ton of global symbols which tend to
conflict with other realtek wifi drivers, force it to be built as
a module.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/staging/rtl8188eu/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Arend van Spriel April 11, 2017, 11:30 a.m. UTC | #1
On 11-4-2017 11:19, Hans de Goede wrote:
> The rtl8188eu driver defines a ton of global symbols which tend to
> conflict with other realtek wifi drivers, force it to be built as
> a module.

Or get rid of those globals as we did to get out of staging :-p

Regards,
Arend

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/staging/rtl8188eu/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8188eu/Kconfig b/drivers/staging/rtl8188eu/Kconfig
> index 94f3879..cb836c5 100644
> --- a/drivers/staging/rtl8188eu/Kconfig
> +++ b/drivers/staging/rtl8188eu/Kconfig
> @@ -1,6 +1,7 @@
>  config R8188EU
>  	tristate "Realtek RTL8188EU Wireless LAN NIC driver"
>  	depends on WLAN && USB && CFG80211
> +	depends on m
>  	select WIRELESS_EXT
>  	select WEXT_PRIV
>  	---help---
>
Greg Kroah-Hartman April 11, 2017, 1:59 p.m. UTC | #2
On Tue, Apr 11, 2017 at 01:30:16PM +0200, Arend Van Spriel wrote:
> On 11-4-2017 11:19, Hans de Goede wrote:
> > The rtl8188eu driver defines a ton of global symbols which tend to
> > conflict with other realtek wifi drivers, force it to be built as
> > a module.
> 
> Or get rid of those globals as we did to get out of staging :-p

Give it time...
diff mbox

Patch

diff --git a/drivers/staging/rtl8188eu/Kconfig b/drivers/staging/rtl8188eu/Kconfig
index 94f3879..cb836c5 100644
--- a/drivers/staging/rtl8188eu/Kconfig
+++ b/drivers/staging/rtl8188eu/Kconfig
@@ -1,6 +1,7 @@ 
 config R8188EU
 	tristate "Realtek RTL8188EU Wireless LAN NIC driver"
 	depends on WLAN && USB && CFG80211
+	depends on m
 	select WIRELESS_EXT
 	select WEXT_PRIV
 	---help---