| Message ID | 20170509130430.GA22190@embeddedgus (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 641c1f4ab7f62278a3a08c0861725ba21a53e5d5 |
| Delegated to: | Kalle Valo |
| Headers | show |
"Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote: > The array field eeprom_data in struct th9k_platform_data > is a fixed size array so it can never be NULL. > > Addresses-Coverity-ID: 1364903 > Cc: Arend Van Spriel <arend.vanspriel@broadcom.com> > Cc: Kalle Valo <kvalo@qca.qualcomm.com> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Patch applied to ath-next branch of ath.git, thanks. 641c1f4ab7f6 ath9k: remove unnecessary code
diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c index fb80ec8..5c3bc28 100644 --- a/drivers/net/wireless/ath/ath9k/eeprom.c +++ b/drivers/net/wireless/ath/ath9k/eeprom.c @@ -143,7 +143,7 @@ bool ath9k_hw_nvram_read(struct ath_hw *ah, u32 off, u16 *data) if (ah->eeprom_blob) ret = ath9k_hw_nvram_read_firmware(ah->eeprom_blob, off, data); - else if (pdata && !pdata->use_eeprom && pdata->eeprom_data) + else if (pdata && !pdata->use_eeprom) ret = ath9k_hw_nvram_read_pdata(pdata, off, data); else ret = common->bus_ops->eeprom_read(common, off, data);
The array field eeprom_data in struct th9k_platform_data is a fixed size array so it can never be NULL. Addresses-Coverity-ID: 1364903 Cc: Arend Van Spriel <arend.vanspriel@broadcom.com> Cc: Kalle Valo <kvalo@qca.qualcomm.com> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- Changes in v2: Rephrase commit log. drivers/net/wireless/ath/ath9k/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)