diff mbox

wireless: wlcore: spi: remove unnecessary variable

Message ID 20170609032430.GA7432@embeddedgus (mailing list archive)
State Accepted
Commit c48c281e7236fc8769dd62e6b13ba090a546027d
Delegated to: Kalle Valo
Headers show

Commit Message

Gustavo A. R. Silva June 9, 2017, 3:24 a.m. UTC
Remove unnecessary variable and refactor the code.

Addresses-Coverity-ID: 1365000
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/net/wireless/ti/wlcore/spi.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Kalle Valo June 9, 2017, 8:12 a.m. UTC | #1
"Gustavo A. R. Silva" <garsilva@embeddedor.com> writes:

> Remove unnecessary variable and refactor the code.
>
> Addresses-Coverity-ID: 1365000
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

I'll remove "wireless:" from the prefix.
Kalle Valo June 13, 2017, 7:07 a.m. UTC | #2
"Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote:

> Remove unnecessary variable and refactor the code.
> 
> Addresses-Coverity-ID: 1365000
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Patch applied to wireless-drivers-next.git, thanks.

c48c281e7236 wlcore: spi: remove unnecessary variable
diff mbox

Patch

diff --git a/drivers/net/wireless/ti/wlcore/spi.c b/drivers/net/wireless/ti/wlcore/spi.c
index fa3547e..d2d899a 100644
--- a/drivers/net/wireless/ti/wlcore/spi.c
+++ b/drivers/net/wireless/ti/wlcore/spi.c
@@ -366,17 +366,14 @@  static int __wl12xx_spi_raw_write(struct device *child, int addr,
 static int __must_check wl12xx_spi_raw_write(struct device *child, int addr,
 					     void *buf, size_t len, bool fixed)
 {
-	int ret;
-
 	/* The ELP wakeup write may fail the first time due to internal
 	 * hardware latency. It is safer to send the wakeup command twice to
 	 * avoid unexpected failures.
 	 */
 	if (addr == HW_ACCESS_ELP_CTRL_REG)
-		ret = __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
-	ret = __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
+		__wl12xx_spi_raw_write(child, addr, buf, len, fixed);
 
-	return ret;
+	return __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
 }
 
 /**