| Message ID | 20170613204259.GA9189@embeddedgus (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
On 06/13/2017 03:42 PM, Gustavo A. R. Silva wrote: > Remove unused variable rtlhal. > > Addresses-Coverity-ID: 1248810 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- NACK!! That variable is used in file core.c in driver rtlwifi, which is loaded and used by rtl8821ae. Please do more than blindly follow Coverity outputs, or improve that tool! Larry > drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c > index 2bc6bac..d158e34 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c > @@ -1360,7 +1360,6 @@ static bool _rtl8821ae_reset_pcie_interface_dma(struct ieee80211_hw *hw, > static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw) > { > struct rtl_priv *rtlpriv = rtl_priv(hw); > - struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); > struct rtl_ps_ctl *ppsc = rtl_psc(rtlpriv); > u8 fw_reason = 0; > struct timeval ts; > @@ -1372,8 +1371,6 @@ static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw) > > ppsc->wakeup_reason = 0; > > - rtlhal->last_suspend_sec = ts.tv_sec; > - > switch (fw_reason) { > case FW_WOW_V2_PTK_UPDATE_EVENT: > ppsc->wakeup_reason = WOL_REASON_PTK_UPDATE; >
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c index 2bc6bac..d158e34 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c @@ -1360,7 +1360,6 @@ static bool _rtl8821ae_reset_pcie_interface_dma(struct ieee80211_hw *hw, static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw) { struct rtl_priv *rtlpriv = rtl_priv(hw); - struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); struct rtl_ps_ctl *ppsc = rtl_psc(rtlpriv); u8 fw_reason = 0; struct timeval ts; @@ -1372,8 +1371,6 @@ static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw) ppsc->wakeup_reason = 0; - rtlhal->last_suspend_sec = ts.tv_sec; - switch (fw_reason) { case FW_WOW_V2_PTK_UPDATE_EVENT: ppsc->wakeup_reason = WOL_REASON_PTK_UPDATE;
Remove unused variable rtlhal. Addresses-Coverity-ID: 1248810 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 3 --- 1 file changed, 3 deletions(-)