[2/2] rsi: update some comments

Commit Message

Dan Carpenter Aug. 25, 2017, 8:40 a.m. UTC

These functions don't return -1 on failure.

Signed-off-by: Dan Carpenter <[e-mail]>

Comments

Kalle Valo Aug. 30, 2017, 4:49 p.m. UTC | #1

Dan Carpenter <[e-mail]> wrote:

> These functions don't return -1 on failure.
> 
> Signed-off-by: Dan Carpenter <[e-mail]>
> 
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> index 25331aa16e8e..e78e87e99804 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> @@ -754,7 +754,7 @@ static int rsi_mac80211_conf_tx(struct ieee80211_hw *hw,
>   * @vif: Pointer to the ieee80211_vif structure.
>   * @key: Pointer to the ieee80211_key_conf structure.
>   *
> - * Return: status: 0 on success, -1 on failure.
> + * Return: status: 0 on success, negative error codes on failure.
>   */
>  static int rsi_hal_key_config(struct ieee80211_hw *hw,
>  			      struct ieee80211_vif *vif,
> @@ -1194,7 +1194,7 @@ static void rsi_set_min_rate(struct ieee80211_hw *hw,
>   * @vif: Pointer to the ieee80211_vif structure.
>   * @sta: Pointer to the ieee80211_sta structure.
>   *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
>   */
>  static int rsi_mac80211_sta_add(struct ieee80211_hw *hw,
>  				struct ieee80211_vif *vif,
> @@ -1306,7 +1306,7 @@ static int rsi_mac80211_sta_add(struct ieee80211_hw *hw,
>   * @vif: Pointer to the ieee80211_vif structure.
>   * @sta: Pointer to the ieee80211_sta structure.
>   *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
>   */
>  static int rsi_mac80211_sta_remove(struct ieee80211_hw *hw,
>  				   struct ieee80211_vif *vif,
> @@ -1426,7 +1426,7 @@ static int rsi_mac80211_set_antenna(struct ieee80211_hw *hw,
>   * @tx_ant: Bitmap for tx antenna
>   * @rx_ant: Bitmap for rx antenna
>   * 
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
>   */
>  static int rsi_mac80211_get_antenna(struct ieee80211_hw *hw,
>  				    u32 *tx_ant, u32 *rx_ant)
> @@ -1533,7 +1533,7 @@ static struct ieee80211_ops mac80211_ops = {
>   * rsi_mac80211_attach() - This function is used to initialize Mac80211 stack.
>   * @common: Pointer to the driver private structure.
>   *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
>   */
>  int rsi_mac80211_attach(struct rsi_common *common)
>  {

2 patches applied to wireless-drivers-next.git, thanks.

fc4386729491 rsi: update some comments
0270639e899e rsi: missing unlocks on error paths

Patch

diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
index 25331aa16e8e..e78e87e99804 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
@@ -754,7 +754,7 @@  static int rsi_mac80211_conf_tx(struct ieee80211_hw *hw,
  * @vif: Pointer to the ieee80211_vif structure.
  * @key: Pointer to the ieee80211_key_conf structure.
  *
- * Return: status: 0 on success, -1 on failure.
+ * Return: status: 0 on success, negative error codes on failure.
  */
 static int rsi_hal_key_config(struct ieee80211_hw *hw,
 			      struct ieee80211_vif *vif,
@@ -1194,7 +1194,7 @@  static void rsi_set_min_rate(struct ieee80211_hw *hw,
  * @vif: Pointer to the ieee80211_vif structure.
  * @sta: Pointer to the ieee80211_sta structure.
  *
- * Return: 0 on success, -1 on failure.
+ * Return: 0 on success, negative error codes on failure.
  */
 static int rsi_mac80211_sta_add(struct ieee80211_hw *hw,
 				struct ieee80211_vif *vif,
@@ -1306,7 +1306,7 @@  static int rsi_mac80211_sta_add(struct ieee80211_hw *hw,
  * @vif: Pointer to the ieee80211_vif structure.
  * @sta: Pointer to the ieee80211_sta structure.
  *
- * Return: 0 on success, -1 on failure.
+ * Return: 0 on success, negative error codes on failure.
  */
 static int rsi_mac80211_sta_remove(struct ieee80211_hw *hw,
 				   struct ieee80211_vif *vif,
@@ -1426,7 +1426,7 @@  static int rsi_mac80211_set_antenna(struct ieee80211_hw *hw,
  * @tx_ant: Bitmap for tx antenna
  * @rx_ant: Bitmap for rx antenna
  * 
- * Return: 0 on success, -1 on failure.
+ * Return: 0 on success, negative error codes on failure.
  */
 static int rsi_mac80211_get_antenna(struct ieee80211_hw *hw,
 				    u32 *tx_ant, u32 *rx_ant)
@@ -1533,7 +1533,7 @@  static struct ieee80211_ops mac80211_ops = {
  * rsi_mac80211_attach() - This function is used to initialize Mac80211 stack.
  * @common: Pointer to the driver private structure.
  *
- * Return: 0 on success, -1 on failure.
+ * Return: 0 on success, negative error codes on failure.
  */
 int rsi_mac80211_attach(struct rsi_common *common)
 {