| Message ID | 20170831144743.GA21261@amd (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
From: Pavel Machek <pavel@ucw.cz> Date: Thu, 31 Aug 2017 16:47:43 +0200 > Dave, Linus -- can you still take the patch? Pavel, please do not bypass maintainers like this. It's really rude, and if you do things like that instead of trying to work properly with us, your relationship with these maintainers will suffer in the long term. Thank you.
Hi! > From: Pavel Machek <pavel@ucw.cz> > Date: Thu, 31 Aug 2017 16:47:43 +0200 > > > Dave, Linus -- can you still take the patch? > > Pavel, please do not bypass maintainers like this. > > It's really rude, and if you do things like that instead of > trying to work properly with us, your relationship with > these maintainers will suffer in the long term. Do you mean I'm being rude to Kalle, or rude to you? In the part you snipped, Kalle asked me to do just that: # I'm not planning to submit pull requests to 4.13 anymore. If you think # this is so important that it needs to be applied in the last minute (I # don't) you could always try to convince Dave to take it directly. ..and as I still believe patch should go in, that's what I did. Best regards, Pavel
From: Pavel Machek <pavel@ucw.cz> Date: Thu, 31 Aug 2017 20:57:19 +0200 > Hi! > >> From: Pavel Machek <pavel@ucw.cz> >> Date: Thu, 31 Aug 2017 16:47:43 +0200 >> >> > Dave, Linus -- can you still take the patch? >> >> Pavel, please do not bypass maintainers like this. >> >> It's really rude, and if you do things like that instead of >> trying to work properly with us, your relationship with >> these maintainers will suffer in the long term. > > Do you mean I'm being rude to Kalle, or rude to you? He said "to David", not "David and Linus".
Hi! On Thu 2017-08-31 12:26:45, David Miller wrote: > From: Pavel Machek <pavel@ucw.cz> > Date: Thu, 31 Aug 2017 20:57:19 +0200 > > > Hi! > > > >> From: Pavel Machek <pavel@ucw.cz> > >> Date: Thu, 31 Aug 2017 16:47:43 +0200 > >> > >> > Dave, Linus -- can you still take the patch? > >> > >> Pavel, please do not bypass maintainers like this. > >> > >> It's really rude, and if you do things like that instead of > >> trying to work properly with us, your relationship with > >> these maintainers will suffer in the long term. > > > > Do you mean I'm being rude to Kalle, or rude to you? > > He said "to David", not "David and Linus". Ok. If I knew you would be replying so quickly, I'd acted differently. I did not want to be rude. But I'd still like to get the patch in. Do you plan to send another pull request to Linus, and can you take the patch, please? Thanks, Pavel
From: Pavel Machek <pavel@ucw.cz> Date: Thu, 31 Aug 2017 21:59:33 +0200 > Do you plan to send another pull request to Linus, and can you take > the patch, please? Yes and yes.
diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c index 08f0477..9915d83 100644 --- a/drivers/net/wireless/ti/wl1251/main.c +++ b/drivers/net/wireless/ti/wl1251/main.c @@ -1571,6 +1571,7 @@ struct ieee80211_hw *wl1251_alloc_hw(void) wl->state = WL1251_STATE_OFF; mutex_init(&wl->mutex); + spin_lock_init(&wl->wl_lock); wl->tx_mgmt_frm_rate = DEFAULT_HW_GEN_TX_RATE; wl->tx_mgmt_frm_mod = DEFAULT_HW_GEN_MODULATION_TYPE;