| Message ID | 20171004155700.18048-3-christoph@boehmwalder.at (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Luca Coelho |
| Headers | show |
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > Separate the function from the previous definition with a newline and > put the `static` keyword on the same line, as it just looks nicer. > > Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at> > --- > drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c > index 0eb815ae97e8..249ee1c7b02f 100644 > --- a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c > +++ b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c > @@ -325,8 +325,8 @@ static u16 channel_id_to_txp(struct iwl_phy_db *phy_db, u16 ch_id) > } > return 0xff; > } > -static > -int iwl_phy_db_get_section_data(struct iwl_phy_db *phy_db, > + > +static int iwl_phy_db_get_section_data(struct iwl_phy_db *phy_db, > u32 type, u8 **data, u16 *size, u16 ch_id) > { > struct iwl_phy_db_entry *entry; Sorry, but this now looks much uglier because the second line is not even aligned to the parenthesis. NACK. -- Luca.
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c index 0eb815ae97e8..249ee1c7b02f 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c @@ -325,8 +325,8 @@ static u16 channel_id_to_txp(struct iwl_phy_db *phy_db, u16 ch_id) } return 0xff; } -static -int iwl_phy_db_get_section_data(struct iwl_phy_db *phy_db, + +static int iwl_phy_db_get_section_data(struct iwl_phy_db *phy_db, u32 type, u8 **data, u16 *size, u16 ch_id) { struct iwl_phy_db_entry *entry;
Separate the function from the previous definition with a newline and put the `static` keyword on the same line, as it just looks nicer. Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at> --- drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)