| Message ID | 20171123155704.44878-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 51ef7925e10688c57186d438e784532e063492e4 |
| Delegated to: | Kalle Valo |
| Headers | show |
On 23-11-17 16:57, Andy Shevchenko wrote: > When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for > the first run, all next ones are okay. > > CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! > scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed > > Seems like something happened with W=1 and wrong kernel doc format. > As a quick fix remove dubious /** in the code. Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for > the first run, all next ones are okay. > > CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! > scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed > > Seems like something happened with W=1 and wrong kernel doc format. > As a quick fix remove dubious /** in the code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> I'll queue this to v4.15.
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for > the first run, all next ones are okay. > > CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! > scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed > > Seems like something happened with W=1 and wrong kernel doc format. > As a quick fix remove dubious /** in the code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Patch applied to wireless-drivers.git, thanks. 51ef7925e106 brcmfmac: Avoid build error with make W=1
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index e3495ea95553..870e00cea29c 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -2070,7 +2070,7 @@ static int brcmf_sdio_txpkt_hdalign(struct brcmf_sdio *bus, struct sk_buff *pkt) return head_pad; } -/** +/* * struct brcmf_skbuff_cb reserves first two bytes in sk_buff::cb for * bus layer usage. */
When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for the first run, all next ones are okay. CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed Seems like something happened with W=1 and wrong kernel doc format. As a quick fix remove dubious /** in the code. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)