| Message ID | 20171128021142.2793-1-eashishkalra@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi Ashish, On Tue, Nov 28, 2017 at 07:41:42AM +0530, Ashish Kalra wrote: > This patch fixes the checkpatch.pl warning: Write in _imperative_mood_ as I said before. Like "Use this..." or "Make this..." > WARNING: Block comments use * on subsequent lines > + /* TODO: > + si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ > > WARNING: Block comments use a trailing */ on a separate line > + si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ > > total: 0 errors, 2 warnings, 200 lines checked No need to mention all of this! > Signed-off-by: Ashish Kalra <eashishkalra@gmail.com> > --- > changes from v1 (https://lkml.org/lkml/2017/11/26/85) > v2: Improved commit message as per review from Morgan Freeman <morganfreeman6991@gmail.com> Your patch subject is again *wrong* here. Look here: https://pastebin.com/X7x89Q4v Please take a look at this : https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches Also, don't send me the patch directly, instead to the relevant maintainer and CC me. Thanks Himanshu Jha
diff --git a/drivers/bcma/driver_pcie2.c b/drivers/bcma/driver_pcie2.c index b1a6e327cb23..cf889fc62ac7 100644 --- a/drivers/bcma/driver_pcie2.c +++ b/drivers/bcma/driver_pcie2.c @@ -83,7 +83,8 @@ static void bcma_core_pcie2_hw_ltr_war(struct bcma_drv_pcie2 *pcie2) bcma_core_pcie2_set_ltr_vals(pcie2); /* TODO: - si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ + *si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); + */ /* enable the LTR */ devstsctr2 |= PCIE2_CAP_DEVSTSCTRL2_LTRENAB;
This patch fixes the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines + /* TODO: + si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ WARNING: Block comments use a trailing */ on a separate line + si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ total: 0 errors, 2 warnings, 200 lines checked Signed-off-by: Ashish Kalra <eashishkalra@gmail.com> --- changes from v1 (https://lkml.org/lkml/2017/11/26/85) v2: Improved commit message as per review from Morgan Freeman <morganfreeman6991@gmail.com> drivers/bcma/driver_pcie2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)