| Message ID | 20180319014032.9394-2-alexey.roslyakov@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
Alexey Roslyakov <alexey.roslyakov@gmail.com> writes: > There are 3 fields in SDIO settings (quirks) to workaround some of the > SG SDIO host particularities, i.e higher align requirements for SG > items. All coding is done the long time ago, but there is no way to > change the driver behavior without patching the kernel. Add missing > devicetree entries. > > Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com> The commit log is not clear for me, what does "all coding is done long time ago" exactly mean? What code and where? > drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Why net-next? To me it looks like this should go to wireless-drivers-next.
Hi, Kalle, good remark, I'll try to make it clear in next version. Thank you. On 19 March 2018 at 23:23, Kalle Valo <kvalo@codeaurora.org> wrote: > Alexey Roslyakov <alexey.roslyakov@gmail.com> writes: > >> There are 3 fields in SDIO settings (quirks) to workaround some of the >> SG SDIO host particularities, i.e higher align requirements for SG >> items. All coding is done the long time ago, but there is no way to >> change the driver behavior without patching the kernel. Add missing >> devicetree entries. >> >> Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com> > > The commit log is not clear for me, what does "all coding is done long > time ago" exactly mean? What code and where? > >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) > > Why net-next? To me it looks like this should go to > wireless-drivers-next. > > -- > Kalle Valo
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c index aee6e5937c41..14135752b659 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c @@ -30,14 +30,20 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, struct device_node *np = dev->of_node; int irq; u32 irqf; - u32 val; if (!np || bus_type != BRCMF_BUSTYPE_SDIO || !of_device_is_compatible(np, "brcm,bcm4329-fmac")) return; - if (of_property_read_u32(np, "brcm,drive-strength", &val) == 0) - sdio->drive_strength = val; + of_property_read_u32(np, "brcm,drive-strength", &sdio->drive_strength); + + sdio->broken_sg_support = + of_property_read_bool(np, "brcm,broken-sg-support"); + + of_property_read_u16(np, "brcm,sd-head-align", &sdio->sd_head_align); + + of_property_read_u16(np, "brcm,sd-sgentry-align", + &sdio->sd_sgentry_align); /* make sure there are interrupts defined in the node */ if (!of_find_property(np, "interrupts", NULL))
There are 3 fields in SDIO settings (quirks) to workaround some of the SG SDIO host particularities, i.e higher align requirements for SG items. All coding is done the long time ago, but there is no way to change the driver behavior without patching the kernel. Add missing devicetree entries. Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)