| Message ID | 20180320114331.4084-1-hariprasath.elango@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On Tue, Mar 20, 2018 at 05:13:31PM +0530, hariprasath.elango@gmail.com wrote: > From: HariPrasath Elango <hariprasath.elango@gmail.com> > > In this case,there is only a single switch case statement.So replacing > by a simple if condition > > Signed-off-by: HariPrasath Elango <hariprasath.elango@gmail.com> > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) What changed from v1? Always put that information below the --- line, like the kernel documentation asks you to do. v3? :) thanks, greg k-h
On Tue, Mar 20, 2018 at 12:47:21PM +0100, Greg KH wrote: > On Tue, Mar 20, 2018 at 05:13:31PM +0530, hariprasath.elango@gmail.com wrote: > > From: HariPrasath Elango <hariprasath.elango@gmail.com> > > > > In this case,there is only a single switch case statement.So replacing > > by a simple if condition > > > > Signed-off-by: HariPrasath Elango <hariprasath.elango@gmail.com> > > --- > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > What changed from v1? Always put that information below the --- line, > like the kernel documentation asks you to do. > > v3? :) > > thanks, > > greg k-h Lesson learned. I will send a v3 with version history included regards, hari prasath
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index 9d8d5d0..730d64f 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -776,14 +776,8 @@ static int connect(struct wiphy *wiphy, struct net_device *dev, } if (sme->crypto.n_akm_suites) { - switch (sme->crypto.akm_suites[0]) { - case WLAN_AKM_SUITE_8021X: + if (sme->crypto.akm_suites[0] == WLAN_AKM_SUITE_8021X) auth_type = IEEE8021; - break; - - default: - break; - } } curr_channel = nw_info->ch;