| Message ID | 20180610071013.GA8771@nishad (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On Sun, Jun 10, 2018 at 12:40:17PM +0530, Nishad Kamdar wrote: > Type used is unsigned char but expected is restricted __le16. > Warning reported by sparse. Part of eudyptula challenge. > The code is buggy, but this fix just papers over it. We discussed this code earlier. https://lkml.org/lkml/2018/6/5/304 regards, dan carpenter
On Tue, Jun 12, 2018 at 04:14:13PM +0300, Dan Carpenter wrote: > On Sun, Jun 10, 2018 at 12:40:17PM +0530, Nishad Kamdar wrote: > > Type used is unsigned char but expected is restricted __le16. > > Warning reported by sparse. Part of eudyptula challenge. > > > > The code is buggy, but this fix just papers over it. We discussed this > code earlier. > > https://lkml.org/lkml/2018/6/5/304 > > regards, > dan carpenter > Ok, I will look at the discussion. Thanks for the review. regards, nishad kamdar
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index e248702ee519..745bf5ca2622 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -1431,7 +1431,7 @@ void wilc_wfi_p2p_rx(struct net_device *dev, u8 *buff, u32 size) freq = ieee80211_channel_to_frequency(curr_channel, NL80211_BAND_2GHZ); - if (!ieee80211_is_action(buff[FRAME_TYPE_ID])) { + if (!ieee80211_is_action(cpu_to_le16(buff[FRAME_TYPE_ID]))) { cfg80211_rx_mgmt(priv->wdev, freq, 0, buff, size, 0); return; }
Type used is unsigned char but expected is restricted __le16. Warning reported by sparse. Part of eudyptula challenge. Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)