| Message ID | 20180803091401.GB10284@redhat.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | mt76x0: build driver only as module | expand |
Stanislaw Gruszka <sgruszka@redhat.com> writes: > There are various symbols that conflicts with mt7601u. > Due to that kernel will not build with allyesconfig. > For now limit the driver to be build only as module. > > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Thanks for the quick patch! > --- a/drivers/net/wireless/mediatek/mt76/Kconfig > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig > @@ -11,7 +11,7 @@ config MT76x2_COMMON > > config MT76x0U > tristate "MediaTek MT76x0U (USB) support" > - depends on MAC80211 > + depends on MAC80211 && m But this feels like an ugly hack to me. Isn't there a better way to fix this? (I don't have time to investigate the error in detail right now.)
On Fri, Aug 03, 2018 at 12:19:20PM +0300, Kalle Valo wrote: > Stanislaw Gruszka <sgruszka@redhat.com> writes: > > > There are various symbols that conflicts with mt7601u. > > Due to that kernel will not build with allyesconfig. > > For now limit the driver to be build only as module. > > > > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> > > Thanks for the quick patch! > > > --- a/drivers/net/wireless/mediatek/mt76/Kconfig > > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig > > @@ -11,7 +11,7 @@ config MT76x2_COMMON > > > > config MT76x0U > > tristate "MediaTek MT76x0U (USB) support" > > - depends on MAC80211 > > + depends on MAC80211 && m > > But this feels like an ugly hack to me. Isn't there a better way to fix > this? (I don't have time to investigate the error in detail right now.) Yes, rename symbols names. And I will do this, just wanted to provide quick fix for the problem. Moreover seems the same thing should be done for mt7601u to avoid build errors and perhaps with mt76 :-( So I'm going to rename functions. Regards Stanislaw
On Fri, Aug 03, 2018 at 11:28:22AM +0200, Stanislaw Gruszka wrote: > > But this feels like an ugly hack to me. Isn't there a better way to fix > > this? (I don't have time to investigate the error in detail right now.) > > Yes, rename symbols names. And I will do this, just wanted to provide > quick fix for the problem. > > Moreover seems the same thing should be done for mt7601u to avoid build > errors and perhaps with mt76 :-( > > So I'm going to rename functions. I have the patches, I'm building kernel with allyesconfig now, it will take a while ... Stanislaw
Stanislaw Gruszka <sgruszka@redhat.com> writes: > On Fri, Aug 03, 2018 at 11:28:22AM +0200, Stanislaw Gruszka wrote: >> > But this feels like an ugly hack to me. Isn't there a better way to fix >> > this? (I don't have time to investigate the error in detail right now.) >> >> Yes, rename symbols names. And I will do this, just wanted to provide >> quick fix for the problem. >> >> Moreover seems the same thing should be done for mt7601u to avoid build >> errors and perhaps with mt76 :-( >> >> So I'm going to rename functions. > > I have the patches, I'm building kernel with allyesconfig now, > it will take a while ... I'm now hoping to send the pull request tomorrow, so if you can submit a proper patch some time today that would be good.
diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig index 850611ad347a..2f25af9a08df 100644 --- a/drivers/net/wireless/mediatek/mt76/Kconfig +++ b/drivers/net/wireless/mediatek/mt76/Kconfig @@ -11,7 +11,7 @@ config MT76x2_COMMON config MT76x0U tristate "MediaTek MT76x0U (USB) support" - depends on MAC80211 + depends on MAC80211 && m depends on USB help This adds support for MT7610U-based wireless USB dongles.
There are various symbols that conflicts with mt7601u. Due to that kernel will not build with allyesconfig. For now limit the driver to be build only as module. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> --- drivers/net/wireless/mediatek/mt76/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)