| Message ID | 20180803182942.4de98df2@canb.auug.org.au (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | linux-next: build failure after merge of the wireless-drivers-next tree | expand |
Stephen Rothwell <sfr@canb.auug.org.au> writes: > After merging the wireless-drivers-next tree, today's linux-next build > (powerpc allyesconfig) failed like this: > > ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x0): multiple definition of `__tracepoint_set_shared_key'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x0): first defined here [...] > Caused by commit > > 7b4859026ccd ("mt76x0: core files") > > and following ones. > > I have just marked that driver broken for now: Thanks Stephen for the report. Odd that kbuild bot didn't catch this, I did have these patches in my pending branch for several days. Stanislaw, could you please send a fix for this ASAP? I can't submit a pull request to Dave until this is fixed.
Hi On Fri, Aug 03, 2018 at 06:29:42PM +1000, Stephen Rothwell wrote: > After merging the wireless-drivers-next tree, today's linux-next build > (powerpc allyesconfig) failed like this: [snip] > diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig > index 850611ad347a..ad56b3ed2be2 100644 > --- a/drivers/net/wireless/mediatek/mt76/Kconfig > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig > @@ -13,6 +13,7 @@ config MT76x0U > tristate "MediaTek MT76x0U (USB) support" > depends on MAC80211 > depends on USB > + depends on BROKEN Would be better to limit driver to be build as module. Hopefully that will fix the issue. I'll post patch in a moment. Thanks Stanislaw
On Fri, Aug 03, 2018 at 11:11:40AM +0200, Stanislaw Gruszka wrote: > Hi > > On Fri, Aug 03, 2018 at 06:29:42PM +1000, Stephen Rothwell wrote: > > After merging the wireless-drivers-next tree, today's linux-next build > > (powerpc allyesconfig) failed like this: > [snip] > > diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig > > index 850611ad347a..ad56b3ed2be2 100644 > > --- a/drivers/net/wireless/mediatek/mt76/Kconfig > > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig > > @@ -13,6 +13,7 @@ config MT76x0U > > tristate "MediaTek MT76x0U (USB) support" > > depends on MAC80211 > > depends on USB > > + depends on BROKEN > Would be better to limit driver to be build as module. > Hopefully that will fix the issue. I'll post patch in a moment. Ok, I made config allyesconfig and .config file looks like this: CONFIG_WLAN_VENDOR_MEDIATEK=y CONFIG_MT7601U=y CONFIG_MT76_CORE=y CONFIG_MT76_USB=y CONFIG_MT76x2_COMMON=y CONFIG_MT76x0U=m However I still not sure if kernel will build this way. Because there can be conflict between kernel symbols and module symbols. So looks as part of quick fix mt7601u should be build also as module. And slower fix will be to rename symbosl names in mt76x0 driver. Regards Stanislaw
diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig index 850611ad347a..ad56b3ed2be2 100644 --- a/drivers/net/wireless/mediatek/mt76/Kconfig +++ b/drivers/net/wireless/mediatek/mt76/Kconfig @@ -13,6 +13,7 @@ config MT76x0U tristate "MediaTek MT76x0U (USB) support" depends on MAC80211 depends on USB + depends on BROKEN help This adds support for MT7610U-based wireless USB dongles.
Hi all, After merging the wireless-drivers-next tree, today's linux-next build (powerpc allyesconfig) failed like this: ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x0): multiple definition of `__tracepoint_set_shared_key'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x30): multiple definition of `__tracepoint_set_key'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x30): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x60): multiple definition of `__tracepoint_mt_rx_dma_aggr'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x60): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x90): multiple definition of `__tracepoint_mt_tx_status'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x90): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0xc0): multiple definition of `__tracepoint_mt_tx_status_cleaned'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0xc0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0xf0): multiple definition of `__tracepoint_mt_tx_dma_done'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0xf0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x120): multiple definition of `__tracepoint_mt_tx'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x120): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x150): multiple definition of `__tracepoint_mt_rx'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x150): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x180): multiple definition of `__tracepoint_read_temp'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x1e0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x1b0): multiple definition of `__tracepoint_temp_mode'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x210): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x1e0): multiple definition of `__tracepoint_bbp_write'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x240): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x210): multiple definition of `__tracepoint_bbp_read'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x270): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x240): multiple definition of `__tracepoint_rf_write'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x2a0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x270): multiple definition of `__tracepoint_rf_read'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x2d0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x2a0): multiple definition of `__tracepoint_ee_read'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x300): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x2d0): multiple definition of `__tracepoint_mt_vend_req'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x330): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x300): multiple definition of `__tracepoint_mt_mcu_msg_send'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x360): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x330): multiple definition of `__tracepoint_mt_submit_urb'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x390): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x360): multiple definition of `__tracepoint_reg_write'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x3c0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/trace.o:(__tracepoints+0x390): multiple definition of `__tracepoint_reg_read'; drivers/net/wireless/mediatek/mt7601u/trace.o:(__tracepoints+0x3f0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o:(.opd+0x30): multiple definition of `mt76_mac_tx_rate_val'; drivers/net/wireless/mediatek/mt7601u/mac.o:(.opd+0x30): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o: in function `.mt76_mac_tx_rate_val': mac.c:(.text.mt76_mac_tx_rate_val+0x0): multiple definition of `.mt76_mac_tx_rate_val'; drivers/net/wireless/mediatek/mt7601u/mac.o:mac.c:(.text.mt76_mac_tx_rate_val+0x0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o:(.opd+0x48): multiple definition of `mt76_mac_wcid_set_rate'; drivers/net/wireless/mediatek/mt7601u/mac.o:(.opd+0x48): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o: in function `.mt76_mac_wcid_set_rate': mac.c:(.text.mt76_mac_wcid_set_rate+0x0): multiple definition of `.mt76_mac_wcid_set_rate'; drivers/net/wireless/mediatek/mt7601u/mac.o:mac.c:(.text.mt76_mac_wcid_set_rate+0x0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o:(.opd+0x78): multiple definition of `mt76_send_tx_status'; drivers/net/wireless/mediatek/mt7601u/mac.o:(.opd+0x78): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o: in function `.mt76_send_tx_status': mac.c:(.text.mt76_send_tx_status+0x0): multiple definition of `.mt76_send_tx_status'; drivers/net/wireless/mediatek/mt7601u/mac.o:mac.c:(.text.mt76_send_tx_status+0x0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o:(.opd+0x120): multiple definition of `mt76_mac_process_rx'; drivers/net/wireless/mediatek/mt7601u/mac.o:(.opd+0x120): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o: in function `.mt76_mac_process_rx': mac.c:(.text.mt76_mac_process_rx+0x0): multiple definition of `.mt76_mac_process_rx'; drivers/net/wireless/mediatek/mt7601u/mac.o:mac.c:(.text.mt76_mac_process_rx+0x0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o:(.opd+0x138): multiple definition of `mt76_mac_wcid_set_key'; drivers/net/wireless/mediatek/mt7601u/mac.o:(.opd+0x138): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o: in function `.mt76_mac_wcid_set_key': mac.c:(.text.mt76_mac_wcid_set_key+0x0): multiple definition of `.mt76_mac_wcid_set_key'; drivers/net/wireless/mediatek/mt7601u/mac.o:mac.c:(.text.mt76_mac_wcid_set_key+0x0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o:(.opd+0x150): multiple definition of `mt76_mac_shared_key_setup'; drivers/net/wireless/mediatek/mt7601u/mac.o:(.opd+0x150): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/mac.o: in function `.mt76_mac_shared_key_setup': mac.c:(.text.mt76_mac_shared_key_setup+0x0): multiple definition of `.mt76_mac_shared_key_setup'; drivers/net/wireless/mediatek/mt7601u/mac.o:mac.c:(.text.mt76_mac_shared_key_setup+0x0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/util.o:(.opd+0x0): multiple definition of `mt76_remove_hdr_pad'; drivers/net/wireless/mediatek/mt7601u/util.o:(.opd+0x0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/util.o: in function `.mt76_remove_hdr_pad': util.c:(.text.mt76_remove_hdr_pad+0x0): multiple definition of `.mt76_remove_hdr_pad'; drivers/net/wireless/mediatek/mt7601u/util.o:util.c:(.text.mt76_remove_hdr_pad+0x0): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/util.o:(.opd+0x18): multiple definition of `mt76_insert_hdr_pad'; drivers/net/wireless/mediatek/mt7601u/util.o:(.opd+0x18): first defined here ld: drivers/net/wireless/mediatek/mt76/mt76x0/util.o: in function `.mt76_insert_hdr_pad': util.c:(.text.mt76_insert_hdr_pad+0x0): multiple definition of `.mt76_insert_hdr_pad'; drivers/net/wireless/mediatek/mt7601u/util.o:util.c:(.text.mt76_insert_hdr_pad+0x0): first defined here Caused by commit 7b4859026ccd ("mt76x0: core files") and following ones. I have just marked that driver broken for now: From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Fri, 3 Aug 2018 18:18:01 +1000 Subject: [PATCH] mt76x0: mark MediaTek MT76x0U (USB) support broken for now Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- drivers/net/wireless/mediatek/mt76/Kconfig | 1 + 1 file changed, 1 insertion(+)