diff mbox series

[1/2] nl80211: Fix nla_put_u8 to u16 for NL80211_WMMR_TXOP

Message ID 20180821062220.29813-2-luca@coelho.fi (mailing list archive)
State Accepted
Delegated to: Johannes Berg
Headers show
Series nl80211: a couple of fixes for WMM reporting | expand

Commit Message

Luca Coelho Aug. 21, 2018, 6:22 a.m. UTC 
From: Haim Dreyfuss <haim.dreyfuss@intel.com>

TXOP (also known as Channel Occupancy Time) is u16 and should be
added using nla_put_u16 instead of u8, fix that.

Fixes: 50f32718e125 ("nl80211: Add wmm rule attribute to NL80211_CMD_GET_WIPHY dump command")
Signed-off-by: Haim Dreyfuss <haim.dreyfuss@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 net/wireless/nl80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 5fb9b7dd9831..1760f38295d5 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -674,8 +674,8 @@  static int nl80211_msg_put_wmm_rules(struct sk_buff *msg,
 				rule->wmm_rule->client[j].cw_max) ||
 		    nla_put_u8(msg, NL80211_WMMR_AIFSN,
 			       rule->wmm_rule->client[j].aifsn) ||
-		    nla_put_u8(msg, NL80211_WMMR_TXOP,
-			       rule->wmm_rule->client[j].cot))
+		    nla_put_u16(msg, NL80211_WMMR_TXOP,
+				rule->wmm_rule->client[j].cot))
 			goto nla_put_failure;
 
 		nla_nest_end(msg, nl_wmm_rule);