| Message ID | 20181005185623.GA14405@embeddedor.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7bfd82bff60ef572b9acef8ca32669ace1f50664 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath10k: remove unnecessary comparison of unsigned integer with < 0 | expand |
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote: > There is no need to compare *ps_state_enable* with < 0 because > such variable is of type u8 (8 bits, unsigned), making it > impossible to hold a negative value. > > Fix this by removing such comparison. > > Addresses-Coverity-ID: 1473921 ("Unsigned compared against 0") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 7bfd82bff60e ath10k: remove unnecessary comparison of unsigned integer with < 0
diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index 2c0cb67..15964b3 100644 --- a/drivers/net/wireless/ath/ath10k/debug.c +++ b/drivers/net/wireless/ath/ath10k/debug.c @@ -2421,7 +2421,7 @@ static ssize_t ath10k_write_ps_state_enable(struct file *file, if (kstrtou8_from_user(user_buf, count, 0, &ps_state_enable)) return -EINVAL; - if (ps_state_enable > 1 || ps_state_enable < 0) + if (ps_state_enable > 1) return -EINVAL; mutex_lock(&ar->conf_mutex);
There is no need to compare *ps_state_enable* with < 0 because such variable is of type u8 (8 bits, unsigned), making it impossible to hold a negative value. Fix this by removing such comparison. Addresses-Coverity-ID: 1473921 ("Unsigned compared against 0") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/net/wireless/ath/ath10k/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)