| Message ID | 20181011080920.GA15131@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e3bfecd5cd37a93c47c146c41d5f1fde7405b592 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath10k: htt: remove some dead code | expand |
Dan Carpenter <dan.carpenter@oracle.com> wrote: > We added an unnecessary condition here in commit a904417fc876 ("ath10k: > add extended per sta tx statistics support"). "legacy_rate_idx" is a u8 > so it can't be negative. The caller doesn't pass negatives either. I > have deleted this code. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. e3bfecd5cd37 ath10k: htt: remove some dead code
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index f2405258a6d3..13717a287848 100644 --- a/drivers/net/wireless/ath/ath10k/htt_rx.c +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c @@ -2680,8 +2680,6 @@ ath10k_accumulate_per_peer_tx_stats(struct ath10k *ar, STATS_OP_FMT(RETRY).ht[1][ht_idx] += pstats->retry_pkts; } else { mcs = legacy_rate_idx; - if (mcs < 0) - return; STATS_OP_FMT(SUCC).legacy[0][mcs] += pstats->succ_bytes; STATS_OP_FMT(SUCC).legacy[1][mcs] += pstats->succ_pkts;
We added an unnecessary condition here in commit a904417fc876 ("ath10k: add extended per sta tx statistics support"). "legacy_rate_idx" is a u8 so it can't be negative. The caller doesn't pass negatives either. I have deleted this code. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- I didn't use the Fixes tag because it's not really a bug.