| Message ID | 20181203133145.12430-1-tiny.windzz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cc4dc97ffc69c253d5aa2c0068545ed6c8bc0bde |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wireless/cw1200: convert to DEFINE_SHOW_ATTRIBUTE | expand |
Yangtao Li <tiny.windzz@gmail.com> writes: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> The prefix should be "cw1200:", I can fix that.
On Mon, Dec 3, 2018 at 9:38 PM Kalle Valo <kvalo@codeaurora.org> wrote: > > Yangtao Li <tiny.windzz@gmail.com> writes: > > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > The prefix should be "cw1200:", I can fix that. > > -- > Kalle Valo OK. Thanks, Yangtao
On Mon, Dec 3, 2018 at 9:43 PM Frank Lee <tiny.windzz@gmail.com> wrote: > > On Mon, Dec 3, 2018 at 9:38 PM Kalle Valo <kvalo@codeaurora.org> wrote: > > > > Yangtao Li <tiny.windzz@gmail.com> writes: > > > > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > > > The prefix should be "cw1200:", I can fix that. The same. Thanks, Yangtao > > > > -- > > Kalle Valo > OK. > > Thanks, > Yangtao
Yangtao Li <tiny.windzz@gmail.com> wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> Patch applied to wireless-drivers-next.git, thanks. cc4dc97ffc69 cw1200: convert to DEFINE_SHOW_ATTRIBUTE
diff --git a/drivers/net/wireless/st/cw1200/debug.c b/drivers/net/wireless/st/cw1200/debug.c index 295cb1a29f25..2231ba08bc1f 100644 --- a/drivers/net/wireless/st/cw1200/debug.c +++ b/drivers/net/wireless/st/cw1200/debug.c @@ -289,19 +289,7 @@ static int cw1200_status_show(struct seq_file *seq, void *v) return 0; } -static int cw1200_status_open(struct inode *inode, struct file *file) -{ - return single_open(file, &cw1200_status_show, - inode->i_private); -} - -static const struct file_operations fops_status = { - .open = cw1200_status_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, - .owner = THIS_MODULE, -}; +DEFINE_SHOW_ATTRIBUTE(cw1200_status); static int cw1200_counters_show(struct seq_file *seq, void *v) { @@ -345,19 +333,7 @@ static int cw1200_counters_show(struct seq_file *seq, void *v) return 0; } -static int cw1200_counters_open(struct inode *inode, struct file *file) -{ - return single_open(file, &cw1200_counters_show, - inode->i_private); -} - -static const struct file_operations fops_counters = { - .open = cw1200_counters_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, - .owner = THIS_MODULE, -}; +DEFINE_SHOW_ATTRIBUTE(cw1200_counters); static ssize_t cw1200_wsm_dumps(struct file *file, const char __user *user_buf, size_t count, loff_t *ppos) @@ -399,11 +375,11 @@ int cw1200_debug_init(struct cw1200_common *priv) goto err; if (!debugfs_create_file("status", 0400, d->debugfs_phy, - priv, &fops_status)) + priv, &cw1200_status_fops)) goto err; if (!debugfs_create_file("counters", 0400, d->debugfs_phy, - priv, &fops_counters)) + priv, &cw1200_counters_fops)) goto err; if (!debugfs_create_file("wsm_dumps", 0200, d->debugfs_phy,
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/net/wireless/st/cw1200/debug.c | 32 ++++---------------------- 1 file changed, 4 insertions(+), 28 deletions(-)