| Message ID | 20190111161812.26325-1-poeschel@lemonage.de (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Samuel Ortiz |
| Headers | show |
| Series | [v5,1/7] nfc: pn533: i2c: "pn532" as dt compatible string | expand |
A gentle ping on this whole patch series. Regards, Lars On Fri, Jan 11, 2019 at 05:18:04PM +0100, Lars Poeschel wrote: > It is favourable to have one unified compatible string for devices that > have multiple interfaces. So this adds simply "pn532" as the devicetree > binding compatible string and makes a note that the old ones are > deprecated. > > Cc: Johan Hovold <johan@kernel.org> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> > --- > Changes in v3: > - This patch is new in v3 > > drivers/nfc/pn533/i2c.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c > index 4389eb4c8d0b..f4eae9dd5305 100644 > --- a/drivers/nfc/pn533/i2c.c > +++ b/drivers/nfc/pn533/i2c.c > @@ -258,6 +258,11 @@ static int pn533_i2c_remove(struct i2c_client *client) > } > > static const struct of_device_id of_pn533_i2c_match[] = { > + { .compatible = "nxp,pn532", }, > + /* > + * NOTE: The use of the compatibles with the trailing "...-i2c" is > + * deprecated and will be removed. > + */ > { .compatible = "nxp,pn533-i2c", }, > { .compatible = "nxp,pn532-i2c", }, > {}, > -- > 2.20.1 >
Second Ping. Regards, Lars On Thu, Feb 28, 2019 at 11:48:01AM +0100, Lars Poeschel wrote: > A gentle ping on this whole patch series. > > Regards, > Lars > > On Fri, Jan 11, 2019 at 05:18:04PM +0100, Lars Poeschel wrote: > > It is favourable to have one unified compatible string for devices that > > have multiple interfaces. So this adds simply "pn532" as the devicetree > > binding compatible string and makes a note that the old ones are > > deprecated. > > > > Cc: Johan Hovold <johan@kernel.org> > > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> > > --- > > Changes in v3: > > - This patch is new in v3 > > > > drivers/nfc/pn533/i2c.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c > > index 4389eb4c8d0b..f4eae9dd5305 100644 > > --- a/drivers/nfc/pn533/i2c.c > > +++ b/drivers/nfc/pn533/i2c.c > > @@ -258,6 +258,11 @@ static int pn533_i2c_remove(struct i2c_client *client) > > } > > > > static const struct of_device_id of_pn533_i2c_match[] = { > > + { .compatible = "nxp,pn532", }, > > + /* > > + * NOTE: The use of the compatibles with the trailing "...-i2c" is > > + * deprecated and will be removed. > > + */ > > { .compatible = "nxp,pn533-i2c", }, > > { .compatible = "nxp,pn532-i2c", }, > > {}, > > -- > > 2.20.1 > >
On Wed, Apr 03, 2019 at 11:47:35AM +0200, Lars Poeschel wrote: > Second Ping. > On Thu, Feb 28, 2019 at 11:48:01AM +0100, Lars Poeschel wrote: > > A gentle ping on this whole patch series. > > On Fri, Jan 11, 2019 at 05:18:04PM +0100, Lars Poeschel wrote: > > > It is favourable to have one unified compatible string for devices that > > > have multiple interfaces. So this adds simply "pn532" as the devicetree > > > binding compatible string and makes a note that the old ones are > > > deprecated. > > > > > > Cc: Johan Hovold <johan@kernel.org> > > > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> You may want to resend this series to netdev now. David Miller will be picking up NFC patches directly from there. Johan
On Mon, Aug 05, 2019 at 02:42:36PM +0200, Johan Hovold wrote: > You may want to resend this series to netdev now. David Miller will be > picking up NFC patches directly from there. Thank you very much for this information. Johannes Berg did reach out to me already. Rebase, test and resend is queued up for one of my next free timeslots. Thanks again, Lars
diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c index 4389eb4c8d0b..f4eae9dd5305 100644 --- a/drivers/nfc/pn533/i2c.c +++ b/drivers/nfc/pn533/i2c.c @@ -258,6 +258,11 @@ static int pn533_i2c_remove(struct i2c_client *client) } static const struct of_device_id of_pn533_i2c_match[] = { + { .compatible = "nxp,pn532", }, + /* + * NOTE: The use of the compatibles with the trailing "...-i2c" is + * deprecated and will be removed. + */ { .compatible = "nxp,pn533-i2c", }, { .compatible = "nxp,pn532-i2c", }, {},
It is favourable to have one unified compatible string for devices that have multiple interfaces. So this adds simply "pn532" as the devicetree binding compatible string and makes a note that the old ones are deprecated. Cc: Johan Hovold <johan@kernel.org> Signed-off-by: Lars Poeschel <poeschel@lemonage.de> --- Changes in v3: - This patch is new in v3 drivers/nfc/pn533/i2c.c | 5 +++++ 1 file changed, 5 insertions(+)