| Message ID | 20190122153823.46270-1-nbd@nbd.name (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/2] mt76: fix per-chain signal strength reporting | expand |
On Tue, Jan 22, 2019 at 04:38:22PM +0100, Felix Fietkau wrote: > Fix an off-by-one error that resulted in not reporting the signal strength > for the first chain > > Signed-off-by: Felix Fietkau <nbd@nbd.name> Not sure how serious this bug is, but I think patch should be marked: Fixes: d9f8934ed147 ("mt76: move mt76x02_mac_process_rx in mt76x02-lib module") Cc: stable@vger.kernel.org # 4.20+ Thanks Stanislaw > --- > drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c > index ce9bb702045f..63fa27d2c404 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c > +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c > @@ -648,7 +648,7 @@ int mt76x02_mac_process_rx(struct mt76x02_dev *dev, struct sk_buff *skb, > > status->chains = BIT(0); > signal = mt76x02_mac_get_rssi(dev, rxwi->rssi[0], 0); > - for (i = 1; i < nstreams; i++) { > + for (i = 0; i < nstreams; i++) { > status->chains |= BIT(i); > status->chain_signal[i] = mt76x02_mac_get_rssi(dev, > rxwi->rssi[i], > -- > 2.17.0 >
> > Fix an off-by-one error that resulted in not reporting the signal strength > for the first chain > > Signed-off-by: Felix Fietkau <nbd@nbd.name> > --- > drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c > index ce9bb702045f..63fa27d2c404 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c > +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c > @@ -648,7 +648,7 @@ int mt76x02_mac_process_rx(struct mt76x02_dev *dev, struct sk_buff *skb, > > status->chains = BIT(0); > signal = mt76x02_mac_get_rssi(dev, rxwi->rssi[0], 0); Here I guess we can do: signal = status->chain_signal[0] = mt76x02_mac_get_rssi(dev, rxwi->rssi[0], 0); and avoid duplicated operations. Regards, Lorenzo > - for (i = 1; i < nstreams; i++) { > + for (i = 0; i < nstreams; i++) { > status->chains |= BIT(i); > status->chain_signal[i] = mt76x02_mac_get_rssi(dev, > rxwi->rssi[i], > -- > 2.17.0 >
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c index ce9bb702045f..63fa27d2c404 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c @@ -648,7 +648,7 @@ int mt76x02_mac_process_rx(struct mt76x02_dev *dev, struct sk_buff *skb, status->chains = BIT(0); signal = mt76x02_mac_get_rssi(dev, rxwi->rssi[0], 0); - for (i = 1; i < nstreams; i++) { + for (i = 0; i < nstreams; i++) { status->chains |= BIT(i); status->chain_signal[i] = mt76x02_mac_get_rssi(dev, rxwi->rssi[i],
Fix an off-by-one error that resulted in not reporting the signal strength for the first chain Signed-off-by: Felix Fietkau <nbd@nbd.name> --- drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)