diff mbox series

[net-next] mt76: fix return value check in mt76_wmac_probe()

Message ID 20190304011000.62693-1-weiyongjun1@huawei.com (mailing list archive)
State Accepted
Delegated to: Felix Fietkau
Headers show
Series [net-next] mt76: fix return value check in mt76_wmac_probe() | expand

Commit Message

Wei Yongjun March 4, 2019, 1:10 a.m. UTC
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: c8846e101502 ("mt76: add driver for MT7603E and MT7628/7688")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
 drivers/net/wireless/mediatek/mt76/mt7603/soc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/soc.c b/drivers/net/wireless/mediatek/mt76/mt7603/soc.c
index e13fea80d970..b920be1f5718 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7603/soc.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7603/soc.c
@@ -23,9 +23,9 @@  mt76_wmac_probe(struct platform_device *pdev)
 	mem_base = devm_ioremap_resource(&pdev->dev, res);
-	if (!mem_base) {
+	if (IS_ERR(mem_base)) {
 		dev_err(&pdev->dev, "Failed to get memory resource\n");
-		return -EINVAL;
+		return PTR_ERR(mem_base);
 	mdev = mt76_alloc_device(&pdev->dev, sizeof(*dev), &mt7603_ops,