diff mbox series

[09/22] iwlwifi: remove iwl-constants.h

Message ID 20190817065200.9701-10-luca@coelho.fi (mailing list archive)
State Superseded
Delegated to: Luca Coelho
Headers show
Series iwlwifi: updates intended for v5.4 2019-08-17 | expand

Commit Message

Luca Coelho Aug. 17, 2019, 6:51 a.m. UTC
From: Shahar S Matityahu <shahar.s.matityahu@intel.com>

This file is included in a few source files, but its content
is never used. Remove it.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kalle Valo Aug. 18, 2019, 1:55 p.m. UTC | #1
Luca Coelho <luca@coelho.fi> writes:

> From: Shahar S Matityahu <shahar.s.matityahu@intel.com>
>
> This file is included in a few source files, but its content
> is never used. Remove it.
>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> index bf0b9ee05c44..2aa5320e9d1a 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> @@ -414,6 +414,7 @@ static const struct iwl_hcmd_names iwl_mvm_legacy_names[] = {
>  	HCMD_NAME(SCAN_ITERATION_COMPLETE),
>  	HCMD_NAME(D0I3_END_CMD),
>  	HCMD_NAME(LTR_CONFIG),
> +	HCMD_NAME(LDBG_CONFIG_CMD),
>  };
>  
>  /* Please keep this array *SORTED* by hex value.

The commit log does not seem to match with the actual patch.
Luca Coelho Aug. 19, 2019, 1:07 p.m. UTC | #2
On Sun, 2019-08-18 at 16:55 +0300, Kalle Valo wrote:
> Luca Coelho <luca@coelho.fi> writes:
> 
> > From: Shahar S Matityahu <shahar.s.matityahu@intel.com>
> > 
> > This file is included in a few source files, but its content
> > is never used. Remove it.
> > 
> > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> > ---
> >  drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> > index bf0b9ee05c44..2aa5320e9d1a 100644
> > --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> > @@ -414,6 +414,7 @@ static const struct iwl_hcmd_names iwl_mvm_legacy_names[] = {
> >  	HCMD_NAME(SCAN_ITERATION_COMPLETE),
> >  	HCMD_NAME(D0I3_END_CMD),
> >  	HCMD_NAME(LTR_CONFIG),
> > +	HCMD_NAME(LDBG_CONFIG_CMD),
> >  };
> >  
> >  /* Please keep this array *SORTED* by hex value.
> 
> The commit log does not seem to match with the actual patch.

Hmmm... somehow a different commit message creeped in.  I'll fix it.

--
Luca.
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
index bf0b9ee05c44..2aa5320e9d1a 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
@@ -414,6 +414,7 @@  static const struct iwl_hcmd_names iwl_mvm_legacy_names[] = {
 	HCMD_NAME(SCAN_ITERATION_COMPLETE),
 	HCMD_NAME(D0I3_END_CMD),
 	HCMD_NAME(LTR_CONFIG),
+	HCMD_NAME(LDBG_CONFIG_CMD),
 };
 
 /* Please keep this array *SORTED* by hex value.