| Message ID | 20190904141611.4780-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4c3e48794dec7cb568974ba3bf2ab62b9c45ca3e |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtlwifi: Fix file release memory leak | expand |
Wei Yongjun <weiyongjun1@huawei.com> wrote: > When using single_open() for opening, single_release() should be > used instead of seq_release(), otherwise there is a memory leak. > > This is detected by Coccinelle semantic patch. > > Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Patch applied to wireless-drivers-next.git, thanks. 4c3e48794dec rtlwifi: Fix file release memory leak
diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.c b/drivers/net/wireless/realtek/rtlwifi/debug.c index a051de16284d..55db71c766fe 100644 --- a/drivers/net/wireless/realtek/rtlwifi/debug.c +++ b/drivers/net/wireless/realtek/rtlwifi/debug.c @@ -88,7 +88,7 @@ static const struct file_operations file_ops_common = { .open = dl_debug_open_common, .read = seq_read, .llseek = seq_lseek, - .release = seq_release, + .release = single_release, }; static int rtl_debug_get_mac_page(struct seq_file *m, void *v)
When using single_open() for opening, single_release() should be used instead of seq_release(), otherwise there is a memory leak. This is detected by Coccinelle semantic patch. Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/net/wireless/realtek/rtlwifi/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)