| Message ID | 20190926225604.9342-1-efremov@linux.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 80e84f36412e0c5172447b6947068dca0d04ee82 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath9k_hw: fix uninitialized variable data | expand |
Denis Efremov <efremov@linux.com> wrote: > Currently, data variable in ar9003_hw_thermo_cal_apply() could be > uninitialized if ar9300_otp_read_word() will fail to read the value. > Initialize data variable with 0 to prevent an undefined behavior. This > will be enough to handle error case when ar9300_otp_read_word() fails. > > Fixes: 80fe43f2bbd5 ("ath9k_hw: Read and configure thermocal for AR9462") > Cc: Rajkumar Manoharan <rmanohar@qca.qualcomm.com> > Cc: John W. Linville <linville@tuxdriver.com> > Cc: Kalle Valo <kvalo@codeaurora.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: stable@vger.kernel.org > Signed-off-by: Denis Efremov <efremov@linux.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 80e84f36412e ath9k_hw: fix uninitialized variable data
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c index 2b29bf4730f6..b4885a700296 100644 --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c @@ -4183,7 +4183,7 @@ static void ar9003_hw_thermometer_apply(struct ath_hw *ah) static void ar9003_hw_thermo_cal_apply(struct ath_hw *ah) { - u32 data, ko, kg; + u32 data = 0, ko, kg; if (!AR_SREV_9462_20_OR_LATER(ah)) return;
Currently, data variable in ar9003_hw_thermo_cal_apply() could be uninitialized if ar9300_otp_read_word() will fail to read the value. Initialize data variable with 0 to prevent an undefined behavior. This will be enough to handle error case when ar9300_otp_read_word() fails. Fixes: 80fe43f2bbd5 ("ath9k_hw: Read and configure thermocal for AR9462") Cc: Rajkumar Manoharan <rmanohar@qca.qualcomm.com> Cc: John W. Linville <linville@tuxdriver.com> Cc: Kalle Valo <kvalo@codeaurora.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: stable@vger.kernel.org Signed-off-by: Denis Efremov <efremov@linux.com> --- drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)