| Message ID | 20191007084805.GA3865@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | be10b09b278fcd64e79e232c88d9152c6f5c2923 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtw88: Fix an error message | expand |
Dan Carpenter <dan.carpenter@oracle.com> wrote: > The WARN_ON() macro doesn't take an error message, the argument is a > condition so this won't display the warning message. > > Fixes: 27e117e4b01b ("rtw88: add deep power save support") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Patch applied to wireless-drivers-next.git, thanks. be10b09b278f rtw88: Fix an error message
diff --git a/drivers/net/wireless/realtek/rtw88/ps.c b/drivers/net/wireless/realtek/rtw88/ps.c index 83db6cf6a219..228309b411ec 100644 --- a/drivers/net/wireless/realtek/rtw88/ps.c +++ b/drivers/net/wireless/realtek/rtw88/ps.c @@ -108,7 +108,7 @@ void rtw_power_mode_change(struct rtw_dev *rtwdev, bool enter) * read/write. It should be treated as fatal error and * requires an entire analysis about the firmware/hardware */ - WARN_ON("Hardware power state locked\n"); + WARN(1, "Hardware power state locked\n"); } } EXPORT_SYMBOL(rtw_power_mode_change);
The WARN_ON() macro doesn't take an error message, the argument is a condition so this won't display the warning message. Fixes: 27e117e4b01b ("rtw88: add deep power save support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/wireless/realtek/rtw88/ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)