diff mbox series

[v2] rtw88: raise LPS threshold to 50, for less power consumption

Message ID 20191101051942.18730-1-yhchuang@realtek.com (mailing list archive)
State Accepted
Commit bf9840ccf8efbdac755772501bd05f6662e1d799
Delegated to: Kalle Valo
Headers show
Series [v2] rtw88: raise LPS threshold to 50, for less power consumption | expand

Commit Message

Tony Chuang Nov. 1, 2019, 5:19 a.m. UTC 
From: Yan-Hsuan Chuang <yhchuang@realtek.com>

The LPS threshold was set to 2, means driver will leave LPS
mode if there is more than 2 frames TX/RX for every 2 seconds.
This makes driver enter/leave LPS frequently even if we just
"ping -i1" to the others.

Apparently we do not want to leave LPS mode if there is only
some background traffics or web surfing. By experiment, set
this to 50 is a more reasonable value to lower the over all
power consumption.

Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
---

v1 -> v2
  * this was originally ("https://patchwork.kernel.org/patch/11211881/")
  * but seems module parameter is not a good idea here, just change
    the default value to 50 for a general solution

 drivers/net/wireless/realtek/rtw88/ps.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Nov. 6, 2019, 5:55 p.m. UTC | #1 
<yhchuang@realtek.com> wrote:

> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> 
> The LPS threshold was set to 2, means driver will leave LPS
> mode if there is more than 2 frames TX/RX for every 2 seconds.
> This makes driver enter/leave LPS frequently even if we just
> "ping -i1" to the others.
> 
> Apparently we do not want to leave LPS mode if there is only
> some background traffics or web surfing. By experiment, set
> this to 50 is a more reasonable value to lower the over all
> power consumption.
> 
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

bf9840ccf8ef rtw88: raise LPS threshold to 50, for less power consumption
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/ps.h b/drivers/net/wireless/realtek/rtw88/ps.h
index 25925eedbad4..19afceca7d0e 100644
--- a/drivers/net/wireless/realtek/rtw88/ps.h
+++ b/drivers/net/wireless/realtek/rtw88/ps.h
@@ -5,7 +5,7 @@ 
 #ifndef __RTW_PS_H_
 #define __RTW_PS_H_
 
-#define RTW_LPS_THRESHOLD	2
+#define RTW_LPS_THRESHOLD	50
 
 #define POWER_MODE_ACK		BIT(6)
 #define POWER_MODE_PG		BIT(4)