[RESEND] crda: Makefile: fix .so compilation line with some compilers

Commit Message

Brian Norris Nov. 7, 2019, 5:37 p.m. UTC

Write the CC rule such that it only tries to produce a single output
file (the .so). When including the .h files in the compiler invocation,
this suggests we should be producing pre-compiled headers too, which
doesn't make sense in this context, and Clang happens not to like.

Signed-off-by: Brian Norris <[e-mail]>
---
On Wed, Nov 06, 2019 at 11:17:49PM +0000, Luis Chamberlain wrote:
> Sure, send me patches.

Done.

 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Luis Chamberlain Nov. 12, 2019, 10:45 p.m. UTC | #1

On Thu, Nov 07, 2019 at 09:37:24AM -0800, Brian Norris wrote:
> Write the CC rule such that it only tries to produce a single output
> file (the .so). When including the .h files in the compiler invocation,
> this suggests we should be producing pre-compiled headers too, which
> doesn't make sense in this context, and Clang happens not to like.
> 
> Signed-off-by: Brian Norris <[e-mail]>
> ---
> On Wed, Nov 06, 2019 at 11:17:49PM +0000, Luis Chamberlain wrote:
> > Sure, send me patches.

Thanks, applied and pushed!

  Luis

Patch

diff --git a/Makefile b/Makefile
index 6169b1f307da..6ca26f341dfa 100644
--- a/Makefile
+++ b/Makefile
@@ -114,9 +114,9 @@  keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
 	$(NQ) '  Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem)
 	$(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
 
-$(LIBREG): regdb.h reglib.h reglib.c
+$(LIBREG): reglib.c regdb.h reglib.h
 	$(NQ) '  CC  ' $@
-	$(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $^
+	$(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $<
 
 install-libreg-headers:
 	$(NQ) '  INSTALL  libreg-headers'