diff mbox series

mac80211: he_support was not set when bringing up a HE mesh interface

Message ID 20191213092636.17736-1-john@phrozen.org (mailing list archive)
State Changes Requested
Delegated to: Johannes Berg
Headers show
Series mac80211: he_support was not set when bringing up a HE mesh interface | expand

Commit Message

John Crispin Dec. 13, 2019, 9:26 a.m. UTC 
From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>

The he_support flag inside bss_conf was not set when a HE mesh interface
gets created. This causes the drivers to not set the HW up correctly.

Fixes: 60ad72da55ac ("mac80211: implement HE support for mesh")

Cc: Sven Eckelmann <seckelmann@datto.com>
Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
---
 net/mac80211/mesh.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Johannes Berg Dec. 13, 2019, 9:32 a.m. UTC | #1 
> From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
> 
> The he_support flag inside bss_conf was not set when a HE mesh interface
> gets created. This causes the drivers to not set the HW up correctly.

This is all wrong ... it doesn't even explain the change.

Also, the subject? Really? I know you can all do better.

> Fixes: 60ad72da55ac ("mac80211: implement HE support for mesh")
> 
> Cc: Sven Eckelmann <seckelmann@datto.com>

The fixes should also be part of the footer.

johannes
diff mbox series

Patch

diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c
index d09b3c789314..98d70f4ef6a4 100644
--- a/net/mac80211/mesh.c
+++ b/net/mac80211/mesh.c
@@ -551,6 +551,8 @@  int mesh_add_he_cap_ie(struct ieee80211_sub_if_data *sdata,
 	    sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10)
 		return 0;
 
+	sdata->vif.bss_conf.he_support = 1;
+
 	if (skb_tailroom(skb) < ie_len)
 		return -ENOMEM;