diff mbox series

ath11k: delete a stray unlock in ath11k_dbg_htt_stats_req()

Message ID 20191213104754.2lwrq2qqokycjjbm@kili.mountain (mailing list archive)
State Accepted
Commit cd21c827a1555276325880ea431a6a27a9186e30
Delegated to: Kalle Valo
Headers show
Series ath11k: delete a stray unlock in ath11k_dbg_htt_stats_req() | expand

Commit Message

Dan Carpenter Dec. 13, 2019, 10:47 a.m. UTC
The callers unlock this lock so this error path has a double unlock.

Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/wireless/ath/ath11k/debug_htt_stats.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Kalle Valo Dec. 18, 2019, 5:54 p.m. UTC | #1
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The callers unlock this lock so this error path has a double unlock.
> 
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

cd21c827a155 ath11k: delete a stray unlock in ath11k_dbg_htt_stats_req()
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c
index 27b301bc1a1b..4b1b1ecd5eae 100644
--- a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c
+++ b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c
@@ -4287,7 +4287,6 @@  int ath11k_dbg_htt_stats_req(struct ath11k *ar)
 	ret = ath11k_dp_tx_htt_h2t_ext_stats_req(ar, type, &cfg_params, cookie);
 	if (ret) {
 		ath11k_warn(ar->ab, "failed to send htt stats request: %d\n", ret);
-		mutex_unlock(&ar->conf_mutex);
 		return ret;
 	}