| Message ID | 20200116125155.166749-1-chenzhou10@huawei.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | [-next] mac80111: fix build error without CONFIG_ATH11K_DEBUGFS | expand |
On Thu, 2020-01-16 at 20:51 +0800, Chen Zhou wrote: > If CONFIG_ATH11K_DEBUGFS is n, build fails: > > drivers/net/wireless/ath/ath11k/debugfs_sta.c: In function ath11k_dbg_sta_open_htt_peer_stats: > drivers/net/wireless/ath/ath11k/debugfs_sta.c:416:4: error: struct ath11k has no member named debug > ar->debug.htt_stats.stats_req = stats_req; > ^~ > and many more similar messages. > > Select ATH11K_DEBUGFS under config MAC80211_DEBUGFS to fix this. Heh, no. You need to find a way in ath11 to fix this. johannes
Hi johannes, On 2020/1/16 20:59, Johannes Berg wrote: > On Thu, 2020-01-16 at 20:51 +0800, Chen Zhou wrote: >> If CONFIG_ATH11K_DEBUGFS is n, build fails: >> >> drivers/net/wireless/ath/ath11k/debugfs_sta.c: In function ath11k_dbg_sta_open_htt_peer_stats: >> drivers/net/wireless/ath/ath11k/debugfs_sta.c:416:4: error: struct ath11k has no member named debug >> ar->debug.htt_stats.stats_req = stats_req; >> ^~ >> and many more similar messages. >> >> Select ATH11K_DEBUGFS under config MAC80211_DEBUGFS to fix this. > > Heh, no. You need to find a way in ath11 to fix this. In file drivers/net/wireless/ath/ath11k/Makefile, "ath11k-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o", that is, debugfs_sta only compiled when CONFIG_MAC80211_DEBUGFS is y. Any suggestions about this? Thanks, Chen Zhou > > johannes > > > . >
+ ath11k Chen Zhou <chenzhou10@huawei.com> writes: > Hi johannes, > > On 2020/1/16 20:59, Johannes Berg wrote: >> On Thu, 2020-01-16 at 20:51 +0800, Chen Zhou wrote: >>> If CONFIG_ATH11K_DEBUGFS is n, build fails: >>> >>> drivers/net/wireless/ath/ath11k/debugfs_sta.c: In function ath11k_dbg_sta_open_htt_peer_stats: >>> drivers/net/wireless/ath/ath11k/debugfs_sta.c:416:4: error: struct ath11k has no member named debug >>> ar->debug.htt_stats.stats_req = stats_req; >>> ^~ >>> and many more similar messages. >>> >>> Select ATH11K_DEBUGFS under config MAC80211_DEBUGFS to fix this. >> >> Heh, no. You need to find a way in ath11 to fix this. > > In file drivers/net/wireless/ath/ath11k/Makefile, "ath11k-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o", > that is, debugfs_sta only compiled when CONFIG_MAC80211_DEBUGFS is y. > > Any suggestions about this? Arnd already fixed this: https://patchwork.kernel.org/patch/11321921/ I'm planning to apply the patch soon.
diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig index 0c93b1b..0f2c2b8 100644 --- a/net/mac80211/Kconfig +++ b/net/mac80211/Kconfig @@ -77,6 +77,7 @@ config MAC80211_LEDS config MAC80211_DEBUGFS bool "Export mac80211 internals in DebugFS" + select ATH11K_DEBUGFS depends on MAC80211 && DEBUG_FS ---help--- Select this to see extensive information about
If CONFIG_ATH11K_DEBUGFS is n, build fails: drivers/net/wireless/ath/ath11k/debugfs_sta.c: In function ath11k_dbg_sta_open_htt_peer_stats: drivers/net/wireless/ath/ath11k/debugfs_sta.c:416:4: error: struct ath11k has no member named debug ar->debug.htt_stats.stats_req = stats_req; ^~ and many more similar messages. Select ATH11K_DEBUGFS under config MAC80211_DEBUGFS to fix this. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Chen Zhou <chenzhou10@huawei.com> --- net/mac80211/Kconfig | 1 + 1 file changed, 1 insertion(+)