| Message ID | 20200219200041.22279-1-Larry.Finger@lwfinger.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c80b18cbb04b7b101af9bd14550f13d9866c646a |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44 | expand |
Larry Finger <Larry.Finger@lwfinger.net> wrote: > For some unexplained reason, commit d1d1a96bdb44 ("rtlwifi: rtl8188ee: > Remove local configuration variable") broke at least one system. As > the only net effect of the change was to remove 2 bytes from the start > of struct phy_status_rpt, this patch adds 2 bytes of padding at the > beginning of the struct. > > Fixes: d1d1a96bdb44 ("rtlwifi: rtl8188ee: Remove local configuration variable") > Cc: Stable <stable@vger.kernel.org> # V5.4+ > Reported-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in> > Tested-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Patch applied to wireless-drivers.git, thanks. c80b18cbb04b rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44
Kalle Valo <kvalo@codeaurora.org> writes: > Larry Finger <Larry.Finger@lwfinger.net> wrote: > >> For some unexplained reason, commit d1d1a96bdb44 ("rtlwifi: rtl8188ee: >> Remove local configuration variable") broke at least one system. As >> the only net effect of the change was to remove 2 bytes from the start >> of struct phy_status_rpt, this patch adds 2 bytes of padding at the >> beginning of the struct. >> >> Fixes: d1d1a96bdb44 ("rtlwifi: rtl8188ee: Remove local configuration variable") >> Cc: Stable <stable@vger.kernel.org> # V5.4+ >> Reported-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in> >> Tested-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > > Patch applied to wireless-drivers.git, thanks. > > c80b18cbb04b rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44 While writing the pull request for Dave I noticed that the commit log does not describe the symptoms in any way. I found the report (connect issues) but in the future please describe the bug from user's point of view in the commit log, not just the solution.
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h index 917729807514..e17f70b4d199 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h @@ -561,6 +561,7 @@ static inline void clear_pci_tx_desc_content(__le32 *__pdesc, int _size) rxmcs == DESC92C_RATE11M) struct phy_status_rpt { + u8 padding[2]; u8 ch_corr[2]; u8 cck_sig_qual_ofdm_pwdb_all; u8 cck_agc_rpt_ofdm_cfosho_a;
For some unexplained reason, commit d1d1a96bdb44 ("rtlwifi: rtl8188ee: Remove local configuration variable") broke at least one system. As the only net effect of the change was to remove 2 bytes from the start of struct phy_status_rpt, this patch adds 2 bytes of padding at the beginning of the struct. Fixes: d1d1a96bdb44 ("rtlwifi: rtl8188ee: Remove local configuration variable") Cc: Stable <stable@vger.kernel.org> # V5.4+ Reported-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in> Tested-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h | 1 + 1 file changed, 1 insertion(+)