diff mbox series

iwlegacy: Remove unneeded variable ret

Message ID 20200221104303.3901-1-vulab@iscas.ac.cn (mailing list archive)
State Accepted
Commit 310443268b2974a3c06e1353e1ddb7593bac0c11
Delegated to: Kalle Valo
Headers show
Series iwlegacy: Remove unneeded variable ret | expand

Commit Message

Xu Wang Feb. 21, 2020, 10:43 a.m. UTC
Remove unneeded variable ret used to store return value.

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 drivers/net/wireless/intel/iwlegacy/3945-mac.c | 4 +---
 drivers/net/wireless/intel/iwlegacy/4965.c     | 3 +--
 2 files changed, 2 insertions(+), 5 deletions(-)

Comments

Stanislaw Gruszka Feb. 22, 2020, 1:24 p.m. UTC | #1
On Fri, Feb 21, 2020 at 06:43:03PM +0800, Xu Wang wrote:
> Remove unneeded variable ret used to store return value.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Kalle Valo March 12, 2020, 1:41 p.m. UTC | #2
Xu Wang <vulab@iscas.ac.cn> wrote:

> Remove unneeded variable ret used to store return value.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>

Patch applied to wireless-drivers-next.git, thanks.

310443268b29 iwlegacy: Remove unneeded variable ret
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
index 206b43b9dff8..9167c3d2711d 100644
--- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
@@ -228,9 +228,7 @@  il3945_set_dynamic_key(struct il_priv *il, struct ieee80211_key_conf *keyconf,
 static int
 il3945_remove_static_key(struct il_priv *il)
 {
-	int ret = -EOPNOTSUPP;
-
-	return ret;
+	return -EOPNOTSUPP;
 }
 
 static int
diff --git a/drivers/net/wireless/intel/iwlegacy/4965.c b/drivers/net/wireless/intel/iwlegacy/4965.c
index 34d0579132ce..fc8fa5818de7 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965.c
@@ -416,7 +416,6 @@  il4965_set_ucode_ptrs(struct il_priv *il)
 {
 	dma_addr_t pinst;
 	dma_addr_t pdata;
-	int ret = 0;
 
 	/* bits 35:4 for 4965 */
 	pinst = il->ucode_code.p_addr >> 4;
@@ -433,7 +432,7 @@  il4965_set_ucode_ptrs(struct il_priv *il)
 		   il->ucode_code.len | BSM_DRAM_INST_LOAD);
 	D_INFO("Runtime uCode pointers are set.\n");
 
-	return ret;
+	return 0;
 }
 
 /**