| Message ID | 20200427104348.13570-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2326aa011967f0afbcba7fe1a005d01f8b12900b |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [net-next] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large() | expand |
Wei Yongjun <weiyongjun1@huawei.com> writes: > 'cmd' is malloced in ath10k_bmi_lz_data_large() and should be freed > before leaving from the error handling cases, otherwise it will cause > memory leak. > > Fixes: d58f466a5dee ("ath10k: add large size for BMI download data for SDIO") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/net/wireless/ath/ath10k/bmi.c | 1 + > 1 file changed, 1 insertion(+) Please don't add "net-next" to wireless-driver patches (ath10k, ath11k etc), because we use different trees. You can add "-next" or "wireless-driver-next" if you want, but even that is not necessary as I apply patches to -next by default.
Wei Yongjun <weiyongjun1@huawei.com> wrote: > 'cmd' is malloced in ath10k_bmi_lz_data_large() and should be freed > before leaving from the error handling cases, otherwise it will cause > memory leak. > > Fixes: d58f466a5dee ("ath10k: add large size for BMI download data for SDIO") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 2326aa011967 ath10k: fix possible memory leak in ath10k_bmi_lz_data_large()
diff --git a/drivers/net/wireless/ath/ath10k/bmi.c b/drivers/net/wireless/ath/ath10k/bmi.c index ea908107581d..5b6db6e66f65 100644 --- a/drivers/net/wireless/ath/ath10k/bmi.c +++ b/drivers/net/wireless/ath/ath10k/bmi.c @@ -380,6 +380,7 @@ static int ath10k_bmi_lz_data_large(struct ath10k *ar, const void *buffer, u32 l NULL, NULL); if (ret) { ath10k_warn(ar, "unable to write to the device\n"); + kfree(cmd); return ret; }
'cmd' is malloced in ath10k_bmi_lz_data_large() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: d58f466a5dee ("ath10k: add large size for BMI download data for SDIO") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/net/wireless/ath/ath10k/bmi.c | 1 + 1 file changed, 1 insertion(+)