| Message ID | 20200512111408.157738-1-chentao107@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [-next] net/wireless/rtl8225: Remove unused variable rtl8225z2_tx_power_ofdm | expand |
On 5/12/20 6:14 AM, ChenTao wrote: > Fix the following warning: > > drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c:609:17: warning: > ‘rtl8225z2_tx_power_ofdm’ defined but not used > static const u8 rtl8225z2_tx_power_ofdm[] = { > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: ChenTao <chentao107@huawei.com> The patch is OK, but the subject is wrong. It should be "[PATCH-next] rtl8187: Remove ...." With that change, ACKed-by: Larry Finger <Larry.Finger@lwfinger.net> Larry
Thanks, i will change it in v2. On 2020/5/12 23:24, Larry Finger wrote: > On 5/12/20 6:14 AM, ChenTao wrote: >> Fix the following warning: >> >> drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c:609:17: warning: >> ‘rtl8225z2_tx_power_ofdm’ defined but not used >> static const u8 rtl8225z2_tx_power_ofdm[] = { >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: ChenTao <chentao107@huawei.com> > > The patch is OK, but the subject is wrong. It should be "[PATCH-next] > rtl8187: Remove ...." > > With that change, ACKed-by: Larry Finger <Larry.Finger@lwfinger.net> > > Larry
diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c index b2616d61b66d..585784258c66 100644 --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c @@ -606,10 +606,6 @@ static const u8 rtl8225z2_tx_power_cck[] = { 0x26, 0x25, 0x21, 0x1b, 0x14, 0x0d, 0x06, 0x03 }; -static const u8 rtl8225z2_tx_power_ofdm[] = { - 0x42, 0x00, 0x40, 0x00, 0x40 -}; - static const u8 rtl8225z2_tx_gain_cck_ofdm[] = { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b,
Fix the following warning: drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c:609:17: warning: ‘rtl8225z2_tx_power_ofdm’ defined but not used static const u8 rtl8225z2_tx_power_ofdm[] = { Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: ChenTao <chentao107@huawei.com> --- drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c | 4 ---- 1 file changed, 4 deletions(-)